Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: integrate WireAuthentication into existing login flow - WPB-14545 #2503

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

johnxnguyen
Copy link
Collaborator

@johnxnguyen johnxnguyen commented Feb 10, 2025

SpikeWPB-14545 Spike Clone - [iOS] Implement Enterprise SSO Login UX Flow

Issue

The existing authentication flow controlled by the AuthenticationController extends past the new flow inside WireAuthentication. For this reason we need to be about to insert the new flow into the old one so that when the new flow ends it connects and continues into the legacy code.

This PR integrates the new WireAuthentication module into the existing authentication flow. It's not entirely complete, but will provide a foundation when the new flow is ready to be fully integrated.

Changes include:

  • Add a new developer flag to enable the new flow
  • Create a WireAuthentcationBridge that will facilitate bidirectional communication in and out of the WireAuthentication module
  • Build and display the root view of the new flow
  • Handle the new flow's completion

Testing

Enabled the developer flag and begin the authentication flow. This will only load and display the module.

Simulator Screen Recording - iPhone 16 - 2025-02-10 at 10 21 13


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the naming, WireAuthenticationBridge. Left small comments nothing blocker

Copy link
Contributor

github-actions bot commented Feb 10, 2025

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 39d2515.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@samwyndham samwyndham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants