-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: integrate WireAuthentication into existing login flow - WPB-14545 #2503
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the naming, WireAuthenticationBridge. Left small comments nothing blocker
WireAuthentication/Sources/WireAuthentication/Components/RootComponent.swift
Show resolved
Hide resolved
WireAuthentication/Sources/WireAuthenticationAPI/WireAuthenticationBridge.swift
Show resolved
Hide resolved
...re-iOS/Sources/Authentication/Event Handlers/WireAuthenticationModuleCompletionHandler.swift
Outdated
Show resolved
Hide resolved
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 39d2515. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool!
Issue
The existing authentication flow controlled by the
AuthenticationController
extends past the new flow insideWireAuthentication
. For this reason we need to be about to insert the new flow into the old one so that when the new flow ends it connects and continues into the legacy code.This PR integrates the new WireAuthentication module into the existing authentication flow. It's not entirely complete, but will provide a foundation when the new flow is ready to be fully integrated.
Changes include:
WireAuthentcationBridge
that will facilitate bidirectional communication in and out of the WireAuthentication moduleTesting
Enabled the developer flag and begin the authentication flow. This will only load and display the module.
Checklist
[WPB-XXX]
.UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: