feat: authentication flow view -> Cloud password login - WPB-15222

[KaterinaWire]

Issue

This PR introduces 2 views for Path 1, 2 and 3, but to fit the design, changes need to be made for 2 reusable elements::
PasswordField and LabeledTextField. As a result of these changes, we need to update Snapshots.

Testing

Checklist

• Title contains a reference JIRA issue number like [WPB-XXX].
• Description is filled and free of optional paragraphs.
• Adds/updates automated tests.

---

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

• Make sure you use the API for UI elements that support large fonts.
• All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
• New UI elements have Accessibility strings for VoiceOver.

[github-actions]

Test Results

  2 files   12 suites   47s ⏱️
130 tests 129 ✅ 1 💤 0 ❌
131 runs  130 ✅ 1 💤 0 ❌

Results for commit 7defe15.

♻️ This comment has been updated with latest results.

[datadog-wireapp]

Datadog Report

Branch report: feat/authentication-ui-cloud-password-unclaimed-v2
Commit report: 595898b
Test service: wire-ios-mono

✅ 0 Failed, 102 Passed, 1 Skipped, 17.01s Total Time

[jullianm]

@KaterinaWire LGTM, left a few non blocking comments, also I don't see the second view ("don't have a wire account..") in the snapshots

[samwyndham]

Nice work!

[samwyndham]

Nice work! We should probably take a look at some of our access modifiers. Most of them don't need to be public - package should be enough.

[johnxnguyen]

question: why do these need to marked @MainActor?

[KaterinaWire]

don't need, fixed

[johnxnguyen]

question: does the password validator need to be injected because it the rules to validate a password are configurable and come from the Wire-iOS project?

[KaterinaWire]

Yes.
We have a protocol

public protocol PasswordValidator {
    func validate(_ password: String) -> Bool
    var localizedRulesDescription: String? { get }
}

which will be reused for export/import backup.

[johnxnguyen]

question: I wonder if this should be part of the view model?

[KaterinaWire]

I would keep it as a private in the view.

1. We don't need to pass password to the multiple views (as it's with email), so there is no need to store it.
2. From the performance point of view, changing the password only updates this view, not the entire ViewModel.

[johnxnguyen]

suggestion: improve readability by breaking up a large body into components like:

var body: some View {
  VStack {
    emailField
    passwordField
    submitButton
    forgotPasswordButton
  }
}

@ViewBuilder
private var emailField: some View (
  LabeledTextField(
    placeholder: nil,
    title: L10n.CloudUserLogin.InputEmail.title,
    string: .constant(viewModel.email
  )
  .disabled(true)
}

@ViewBuilder
private var passwordField: some View {
  ...
}

[KaterinaWire]

done

[johnxnguyen]

I think this should be done in the view model:

viewModel.recoverPassword()

[KaterinaWire]

done

[johnxnguyen]

suggestion: run this in a detached task, otherwise it will run on the main thread and block the UI.

[KaterinaWire]

done

[johnxnguyen]

suggestion: move this to the view model. If you keep in here, it should be marked as private (SwiftUI best practice)

[KaterinaWire]

made it private

[johnxnguyen]

suggestion: increase readability by breaking this up into components and using view builders.

[KaterinaWire]

done

[johnxnguyen]

suggestion: mark everything except email private.

[KaterinaWire]

done

[johnxnguyen]

I know I was the one to separate LoginViaEmail and LoginOrRegisterViaEmail, but i wonder if it would make sense to combine them since they are almost identical. What do you think?

[KaterinaWire]

@johnxnguyen I would keep it separately. I see some Pros and Cons, but maybe we can keep it separately for now.
Cons:

• duplicate code

Pros:

• view model for LoginOrRegisterViaEmail contains additional methods, that should be nil for login without registration;
• single responsibility;

[KaterinaWire]

But we will have one more similar view and will increase code duplication. I combined LoginViaEmail and LoginOrRegisterViaEmail