Skip to content
This repository has been archived by the owner on Aug 22, 2023. It is now read-only.

Updated performance timing to ticks instead of time. #25

Merged
merged 1 commit into from
Sep 23, 2020
Merged

Updated performance timing to ticks instead of time. #25

merged 1 commit into from
Sep 23, 2020

Conversation

FelixWohlfrom
Copy link
Contributor

@FelixWohlfrom FelixWohlfrom commented Jul 17, 2020

This will make the overall implementation a lot easier
since we only need to take care of one time for both
performance and program wheel, not two separate ones.

Related: #16

This will make the overall implementation a lot easier
since we only need to take care of one time for both
performance and program wheel, not two separate ones.

Resolves #16
@Tiedye
Copy link
Collaborator

Tiedye commented Jul 21, 2020

It does not resolve #16, #16 is a different issue.

@FelixWohlfrom
Copy link
Contributor Author

Yes, you are right. I confused it, since the commit was an outcome out of discussion in #16.

@mozi-h
Copy link
Member

mozi-h commented Sep 10, 2020

This has been sitting for a while now.
So, what exactly would be the benefit of only using ticks?

Separating them making sense as time is always tied to elapsed real time, when ticks are based on a changeable speed (that of the "crank"). Whether timed or ticked, the question of what happens to events after the time was edited remains (e.g. You post-edit in a crank speed change in the beginning of a performance).
So far, not making this editable (or only the last one) gets around this, whilst restricting performance construction (and editing), which would be nice to have.

@FelixWohlfrom
Copy link
Contributor Author

The benefit would be a simplified implementation. As far as @Zakgriffin (or @ollpu) mentioned in discord (it's quite some time, sorry that I don't remember who of you it was), our playback framework used to play the audio also only uses ticks to play the song.
So if we stick to ticks, we will make our life a lot easier since we won't need any synchronization mechanism between ticks and time.

My proposal would be to do it in a staged approach - Version 1 works with ticks only (we will have enough to do to get that working) and once that is ready, we can continue to get real timed events then in Version 2 or whatever version after.

@mozi-h mozi-h merged commit eb06ad4 into wintergatan-community:master Sep 23, 2020
@FelixWohlfrom FelixWohlfrom deleted the dev branch September 23, 2020 22:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants