Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor search command #912

Merged
merged 7 commits into from
Dec 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Added config validations.
- sfsu will now crash with an error message if `no_junction` is enabled.
- Added `app download --outdated` flag to download new versions of all outdated apps
- Warnings in search command for deprecated usage
- Support `json` flag in `search` command

### Changed

- Removed `json` flag from `app download` command
- Download progress bars now show app name instead of url leaf
- Download hash checks now report to a progress bar rather than a print message for each
- Logs will now go into `<PWD>/logs` if running with debug assertions
- `search` command no longer hides `[installed]` label if only searching for installed apps

### Removed

Expand Down
2 changes: 1 addition & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ license = "MIT OR Apache-2.0"
name = "sfsu"
publish = true
repository = "https://github.com/winpax/sfsu"
version = "1.15.0"
version = "1.16.0"

[[bench]]
harness = false
Expand Down
6 changes: 3 additions & 3 deletions src/commands/app/download.rs
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,6 @@ use crate::{
#[derive(Debug, Clone, Parser)]
/// Download the specified app.
pub struct Args {
#[clap(short, long, help = "Use the specified architecture, if the app supports it", default_value_t = Architecture::ARCH)]
arch: Architecture,

#[clap(short = 'H', long, help = "Disable hash validation")]
no_hash_check: bool,

Expand All @@ -41,6 +38,9 @@ pub struct Args {

#[clap(long, help = "Download new versions of all outdated apps")]
outdated: bool,

#[clap(from_global)]
arch: Architecture,
}

impl super::Command for Args {
Expand Down
Loading
Loading