Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(error): Polish Incomplete handling #724

Merged
merged 3 commits into from
Jan 29, 2025
Merged

Conversation

epage
Copy link
Collaborator

@epage epage commented Jan 29, 2025

This is mostly focused on smoothing out ErrMode::is_incomplete to ParserError::is_incomplete so we can remove the former

This has breaking changes from main but not from a prior release

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13039876435

Details

  • 9 of 21 (42.86%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.01%) to 40.475%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/combinator/debug/internals.rs 0 1 0.0%
src/stream/recoverable.rs 0 1 0.0%
src/combinator/impls.rs 3 5 60.0%
src/binary/bits/mod.rs 4 7 57.14%
src/error.rs 2 7 28.57%
Files with Coverage Reduction New Missed Lines %
src/binary/bits/mod.rs 1 77.5%
src/error.rs 1 22.14%
Totals Coverage Status
Change from base Build 13038037213: 0.01%
Covered Lines: 1294
Relevant Lines: 3197

💛 - Coveralls

@epage epage merged commit f2e15cd into winnow-rs:main Jan 29, 2025
16 checks passed
@epage epage deleted the incomplete branch January 29, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants