-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add impl ErrorConvert
for ContextError
#500
Add impl ErrorConvert
for ContextError
#500
Conversation
Huh, weird. It wouldn't build on my machine either but I assumed I had something configured wrong. 🤔 |
e5fcf9b
to
fc65414
Compare
I've got a PR open for Winnow (winnow-rs/winnow#500) that should hopefully render this unnecessary once it's merged & released, but until then this lets me use context with bit parsers (and simplifies invocation for `bits::bits`!)
Let's remove that for now as its unrelated to the problem at hand and it would be good to understand the use case for why someone is doing it. |
fc65414
to
40a0a15
Compare
done |
Pull Request Test Coverage Report for Build 8643968260Details
💛 - Coveralls |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #500 +/- ##
=======================================
Coverage 41.81% 41.81%
=======================================
Files 18 18
Lines 3047 3049 +2
=======================================
+ Hits 1274 1275 +1
- Misses 1773 1774 +1 ☔ View full report in Codecov by Sentry. |
Quick fix for #498
I didn't touch TreeError because I couldn't see a particularly easy way of converting input types on it other than rewriting the entire tree which seemed a bit over the top.
I added the
InputError
->ContextError
conversion because I could rather than because I needed it, I can remove it if you don't want it.