Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ascii): Accept 0 with dec_uint/dec_int #476

Merged
merged 2 commits into from
Feb 14, 2024
Merged

fix(ascii): Accept 0 with dec_uint/dec_int #476

merged 2 commits into from
Feb 14, 2024

Conversation

epage
Copy link
Collaborator

@epage epage commented Feb 14, 2024

Fixes #475

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7904072294

Details

  • 0 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 41.864%

Totals Coverage Status
Change from base Build 7888235307: 0.3%
Covered Lines: 1271
Relevant Lines: 3036

💛 - Coveralls

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (49d175e) 41.51% compared to head (c9f000a) 41.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #476      +/-   ##
==========================================
+ Coverage   41.51%   41.86%   +0.34%     
==========================================
  Files          18       18              
  Lines        3035     3036       +1     
==========================================
+ Hits         1260     1271      +11     
+ Misses       1775     1765      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@epage epage merged commit 7c88f25 into winnow-rs:main Feb 14, 2024
17 checks passed
@epage epage deleted the dec branch February 14, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: dec_int and dec_uint no longer parse "0"
2 participants