Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(error)!: Consistently pass Checkpoints around #470

Merged
merged 5 commits into from
Feb 12, 2024

Conversation

epage
Copy link
Collaborator

@epage epage commented Feb 12, 2024

Fixes #384

@epage epage changed the title fix(error)!: Con fix(error)!: Consistently pass Checkpoints around Feb 12, 2024
@coveralls
Copy link

coveralls commented Feb 12, 2024

Pull Request Test Coverage Report for Build 7877457138

Details

  • -75 of 105 (28.57%) changed or added relevant lines in 9 files are covered.
  • 8 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.8%) to 41.785%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/combinator/branch.rs 2 3 66.67%
src/parser.rs 0 1 0.0%
src/combinator/core.rs 0 4 0.0%
src/ascii/mod.rs 0 5 0.0%
src/combinator/parser.rs 6 13 46.15%
src/error.rs 7 20 35.0%
src/stream/mod.rs 0 14 0.0%
src/combinator/multi.rs 14 44 31.82%
Files with Coverage Reduction New Missed Lines %
src/binary/bits/mod.rs 1 80.77%
src/ascii/mod.rs 2 53.87%
src/error.rs 2 23.73%
src/stream/mod.rs 3 25.7%
Totals Coverage Status
Change from base Build 7873929027: -0.8%
Covered Lines: 1297
Relevant Lines: 3104

💛 - Coveralls

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 75 lines in your changes are missing coverage. Please review.

Comparison is base (c73f840) 42.62% compared to head (8cec29c) 41.78%.

Files Patch % Lines
src/combinator/multi.rs 31.81% 30 Missing ⚠️
src/stream/mod.rs 0.00% 14 Missing ⚠️
src/error.rs 35.00% 13 Missing ⚠️
src/combinator/parser.rs 46.15% 7 Missing ⚠️
src/ascii/mod.rs 0.00% 5 Missing ⚠️
src/combinator/core.rs 0.00% 4 Missing ⚠️
src/combinator/branch.rs 66.66% 1 Missing ⚠️
src/parser.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #470      +/-   ##
==========================================
- Coverage   42.62%   41.78%   -0.85%     
==========================================
  Files          18       18              
  Lines        3092     3104      +12     
==========================================
- Hits         1318     1297      -21     
- Misses       1774     1807      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@epage epage merged commit d049ebd into winnow-rs:main Feb 12, 2024
15 of 17 checks passed
@epage epage deleted the context branch February 12, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkpoint the start of a Context
2 participants