Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stream)!: Limit Checkpoints to their stream type #446

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

epage
Copy link
Collaborator

@epage epage commented Feb 2, 2024

Fixes #444

BREAKING CHANGE: This adds an extra generic parameter to Checkpoint<T, S>

Fixes winnow-rs#444

BREAKING CHANGE: This adds an extra generic parameter to `Checkpoint<T, S>`
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7762184584

  • -13 of 27 (51.85%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 41.823%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/stream/mod.rs 14 27 51.85%
Totals Coverage Status
Change from base Build 7762181441: 0.2%
Covered Lines: 1317
Relevant Lines: 3149

💛 - Coveralls

@epage epage changed the title fix(stream)!: Limut Checkpoints to their stream type fix(stream)!: Limit Checkpoints to their stream type Feb 2, 2024
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (ec3e3d3) 41.66% compared to head (ddf9912) 41.82%.

Files Patch % Lines
src/stream/mod.rs 51.85% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #446      +/-   ##
==========================================
+ Coverage   41.66%   41.82%   +0.16%     
==========================================
  Files          19       19              
  Lines        3142     3149       +7     
==========================================
+ Hits         1309     1317       +8     
+ Misses       1833     1832       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@epage epage merged commit 7e2d627 into winnow-rs:main Feb 2, 2024
17 checks passed
@epage epage deleted the checkpoint branch February 2, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkpoint should have PhantomData of the stream
2 participants