Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Unstable support for error recovery #388

Merged
merged 1 commit into from
Feb 2, 2024
Merged

feat: Unstable support for error recovery #388

merged 1 commit into from
Feb 2, 2024

Conversation

epage
Copy link
Collaborator

@epage epage commented Dec 7, 2023 •
edited
Loading

The main things this leave out include:

  • A happy path for error reporting
  • Examples

First step towards #96

@epage epage marked this pull request as draft December 7, 2023 18:17
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 7, 2023
View reviewed changes
@epage
Copy link
Collaborator Author

epage commented Jan 22, 2024

Created rust-lang/rust#120254 for the ICE

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 22, 2024
View reviewed changes
@epage
feat: Unstable support for error recovery
78cc820 
The main things this leave out include:
- A happy path for error reporting
- Examples

First step towards winnow-rs#96
@epage epage changed the title WIP: feat: Error recovery support feat: Unstable support for error recovery Feb 2, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 2, 2024
View reviewed changes
@epage epage marked this pull request as ready for review February 2, 2024 21:22
@codecov Codecov
Copy link

codecov bot commented Feb 2, 2024 •
edited
Loading

Codecov Report

Attention: 167 lines in your changes are missing coverage. Please review.

Comparison is base (1feb518) 43.97% compared to head (78cc820) 41.82%.

Files Patch % Lines
src/stream/mod.rs 0.00% 92 Missing ⚠️
src/combinator/parser.rs 0.00% 48 Missing ⚠️
src/parser.rs 0.00% 24 Missing ⚠️
src/error.rs 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #388      +/-   ##
==========================================
- Coverage   43.97%   41.82%   -2.15%     
==========================================
  Files          19       19              
  Lines        2977     3142     +165     
==========================================
+ Hits         1309     1314       +5     
- Misses       1668     1828     +160

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Feb 2, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7761790180

  • -167 of 167 (0.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.2%) to 41.82%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/error.rs 0 3 0.0%
src/parser.rs 0 24 0.0%
src/combinator/parser.rs 0 48 0.0%
src/stream/mod.rs 0 92 0.0%
Totals Coverage Status
Change from base Build 7733317776: -2.2%
Covered Lines: 1314
Relevant Lines: 3142
💛 - Coveralls

github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 2, 2024
View reviewed changes
@epage epage merged commit 70effc9 into winnow-rs:main Feb 2, 2024
17 of 19 checks passed
@epage epage deleted the recover branch February 2, 2024 21:43
This was referenced Feb 2, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@epage @coveralls