Skip to content
This repository has been archived by the owner on Mar 30, 2021. It is now read-only.

Handle string and binary encoded HMACs #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handle string and binary encoded HMACs #7

wants to merge 1 commit into from

Conversation

dougneal
Copy link

Other implementations of Credstash can store the HMACs as binaries. Handle this case and decode as appropriate.

@dougneal
Handle string and binary encoded HMACs
beac1a3 
Other implementations of Credstash can store the HMACs as binaries.
Handle this case and decode as appropriate.
@warroyo
Copy link

warroyo commented May 23, 2018

any update on this? I am running into this issue now

@martin-dodo-hartmann
Copy link

Does anyone maintain this anymore? We recently ran into the same problem, which will get fixed with this PR.

@kgaughan
Copy link

@dougneal Your change looks to heavily overlap with the change in #12. Could you verify that they're exactly the same? I've forked this project at kgaughan/gcredstash with the hope of fixing various issues, modernising the build, and giving it an active maintainer again.

kgaughan added a commit to kgaughan/gcredstash that referenced this pull request Jun 10, 2023
@kgaughan
Python credstash uses strings for the HMAC
ecd8683 
This is a slight adaptation of winebarrel#12.

It also fixes winebarrel#7.
@kgaughan kgaughan mentioned this pull request Jun 10, 2023
Merged
kgaughan added a commit to kgaughan/gcredstash that referenced this pull request Jun 10, 2023
@kgaughan
Python credstash uses strings for the HMAC (#11)
1d6274a 
This is a slight adaptation of winebarrel#12.

It also fixes winebarrel#7.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dougneal @warroyo @martin-dodo-hartmann @kgaughan