Skip to content

Commit

Permalink
Change to enforce CacheTimeout
Browse files Browse the repository at this point in the history
Previously, CacheTimeout only affected the expiration time sent to the
client; the code treated cookies as valid for 30 days.
  • Loading branch information
nepella committed Nov 26, 2024
1 parent 9d6124c commit 759ae1a
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions ldapauth.go
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,12 @@ func New(ctx context.Context, next http.Handler, config *Config, name string) (h
Path: config.CacheCookiePath,
Secure: config.CacheCookieSecure,
}
// This is called within the constructor using the default MaxAge. If it's
// not called again here, our CacheTimeout would affect only the expiration
// time sent in the 'set-cookie' header but not the actual check of the
// HMACed timestamp in the cookie, so a cookie would be accepted for 30
// days.
store.MaxAge(store.Options.MaxAge)

return &LdapAuth{
name: name,
Expand Down

0 comments on commit 759ae1a

Please sign in to comment.