Feat/startpage new arch #70
Conversation
| } | ||
|
|
| SPAN_TITLE_ELEMENT_SELECTOR = '.w-gl__result-title > h3, .result-title > h2 '; | ||
| BADGE_ELEMENT_SELECTOR = this.SPAN_TITLE_ELEMENT_SELECTOR; // Element that will hold the badge. | ||
| ANCHOR_ELEMENT_SELECTOR = '.w-gl__result-url, .css-1su0nhd > span, .css-1qvmgy0 > span'; // URL breadcumb | ||
| /** |
There was a problem hiding this comment.
Missing new lines between property and method.
js/search/startpage.js
Outdated
| ENGINE_LAYOUT_SELECTOR = '.w-gl--desktop, .w-gl'; | ||
| RESULT_CONTAINER_SELECTOR = '.w-gl__result, .result'; | ||
| SPAN_TITLE_ELEMENT_SELECTOR = '.w-gl__result-title > h3, .result-title > h2 '; | ||
| BADGE_ELEMENT_SELECTOR = this.SPAN_TITLE_ELEMENT_SELECTOR; // Element that will hold the badge. |
There was a problem hiding this comment.
Place the comment above the declaration as a block comment.
js/search/startpage.js
Outdated
| RESULT_CONTAINER_SELECTOR = '.w-gl__result, .result'; | ||
| SPAN_TITLE_ELEMENT_SELECTOR = '.w-gl__result-title > h3, .result-title > h2 '; | ||
| BADGE_ELEMENT_SELECTOR = this.SPAN_TITLE_ELEMENT_SELECTOR; // Element that will hold the badge. | ||
| ANCHOR_ELEMENT_SELECTOR = '.w-gl__result-url, .css-1su0nhd > span, .css-1qvmgy0 > span'; // URL breadcumb |
There was a problem hiding this comment.
Place the comment above the declaration as a block comment.
js/search/startpage.js
Outdated
| class DdgSearchModule extends GenericSearchModule { | ||
| ENGINE_LAYOUT_SELECTOR = '.w-gl--desktop, .w-gl'; | ||
| RESULT_CONTAINER_SELECTOR = '.w-gl__result, .result'; | ||
| SPAN_TITLE_ELEMENT_SELECTOR = '.w-gl__result-title > h3, .result-title > h2 '; |
There was a problem hiding this comment.
Redundant space at the end of the selector.
js/search/startpage.js
Outdated
| allMoved: true, | ||
| theme: { | ||
| fontSize: '80%', | ||
| color: document.documentElement.classList.contains("dark" || "startpage-html--night") ? '#a7b1fc' : '#000000', |
There was a problem hiding this comment.
Use single quotes. Spaces before and after parentheses. What the hell is the condition anyway? That won't do what you think it will.
js/search/startpage.js
Outdated
| } ); | ||
| containerElement.querySelector( this.BADGE_ELEMENT_SELECTOR ).appendChild( badgeElement ); | ||
|
|
||
| //Rewrite URL breadcrumb |
There was a problem hiding this comment.
Missing space after the comment starts. Please just install ESLint.
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Two lines after a class definition and before other code.
js/search/startpage.js
Outdated
| } | ||
| } | ||
|
|
||
| document.onreadystatechange = () => { |
There was a problem hiding this comment.
window.addEventListener, or awaitElement.
manifests/chrome_dev.json
Outdated
| @@ -1,121 +0,0 @@ | |||
| { | |||
There was a problem hiding this comment.
Please review your changes before you commit them. This should NOT had been deleted.
ManagarmrWhisperer
force-pushed
the
feat/StartpageNewArch
branch
from
5b83279 to
652e9e5
Compare
ManagarmrWhisperer
force-pushed
the
feat/StartpageNewArch
branch
from
652e9e5 to
34d8be6
Compare
| } | ||
|
|
| }, | ||
| { | ||
| id: 'ddg', | ||
| supportsFilter: true, | ||
| supportsRewrite: true, | ||
| supportsRewrite: true |
There was a problem hiding this comment.
I've already told you there's no need for lines unrelated to the startpage change to be modified.
| } ); | ||
|
|
||
|
|
||
| class DdgSearchModule extends GenericSearchModule { |
| } | ||
|
|
||
|
|
| if ( event.target.readyState === 'complete' ) { | ||
| DdgSearchModule.invoke( wikis ); | ||
| } | ||
|
|
No description provided.