Various cleanups after merging ACI/PNI #884
GitHub Actions / clippy
succeeded
Apr 13, 2024 in 1s
clippy
2 warnings
Details
Results
| Message level | Amount |
|---|---|
| Internal compiler error | 0 |
| Error | 0 |
| Warning | 2 |
| Note | 0 |
| Help | 0 |
Versions
- rustc 1.77.1 (7cf61ebde 2024-03-27)
- cargo 1.77.1 (e52e36006 2024-03-26)
- clippy 0.1.77 (7cf61eb 2024-03-27)
Annotations
Check warning on line 185 in libsignal-service/src/cipher.rs
github-actions / clippy
the function `message_decrypt_prekey` doesn't need a mutable reference
warning: the function `message_decrypt_prekey` doesn't need a mutable reference
--> libsignal-service/src/cipher.rs:185:21
|
185 | &mut self.protocol_store.clone(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
= note: `#[warn(clippy::unnecessary_mut_passed)]` on by default
Check warning on line 720 in libsignal-service/src/account_manager.rs
github-actions / clippy
called `is_none()` after searching an `Iterator` with `find`
warning: called `is_none()` after searching an `Iterator` with `find`
--> libsignal-service/src/account_manager.rs:717:24
|
717 | if pni_registration_ids
| ________________________^
718 | | .iter()
719 | | .find(|(_k, v)| **v == regid)
720 | | .is_none()
| |__________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some
= note: `#[warn(clippy::search_is_some)]` on by default
help: consider using
|
717 ~ if !pni_registration_ids
718 + .iter().any(|(_k, v)| **v == regid)
|
Loading