Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump libsignal client to 0.62 #345

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bump libsignal client to 0.62 #345

wants to merge 1 commit into from

Conversation

rubdos
Copy link
Member

@rubdos rubdos commented Nov 16, 2024

This rewires some APIs to accept DeviceId instead of u32.

It also removes the ServiceIdExt trait, since
signalapp/libsignal#595 got merged. The aci() and pni() methods can be replaced with simple into() or from() calls, depending on context.

This rewires some APIs to accept DeviceId instead of u32.

It also removes the ServiceIdExt trait, since
signalapp/libsignal#595 got merged.  The `aci()`
and `pni()` methods can be replaced with simple `into()` or `from()`
calls, depending on context.
@rubdos rubdos requested a review from gferon November 16, 2024 09:42
@rubdos
Copy link
Member Author

rubdos commented Nov 16, 2024

I made an attempt to make our DEFAULT_DEVICE_ID to be of libsignal_protocol::DeviceId type, instead of u32, but that isn't possible because the wrapped value is private, and From::from is not const. I could propose a Default implementation, or a custom default function upstream, to get rid of the weak type...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant