-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wrage? #315
wrage? #315
Conversation
Needs to check the |
There's some code duplication (frontend_qt code also exists in frontend_sdl). I was thinking of making the initFrontend function handle that common code in emulator.cpp and call an initFrontendInternal which would be the frontend specific code defined in frontend_sdl/qt but not sure how common the duplicated code is (would it be needed for every possible frontend panda might have in the future?) |
Apart from ease to adding new frontends, I think this makes it easier to create unit tests in the future. Say you want to run the emulator class as a standalone, only initialize opengl for testing. You could add another ifdef in emulator.cpp, or you could simply define |
Will be reopened at a later date |
Can sdl_frontend.hpp include <filesystem> rq |
Wait you included it in the .cpp not .hpp |
Use a different loading function for android, otherwise it would not load some functions like glad_glTexStorage2D which normally gets loaded at load_GL_VERSION_4_2 which android was probably missing, and now loads from load_GL_ES_VERSION_3_0.
A standalone function is also helpful to further separate the emulator core from the UI