Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add set extend operation #663

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Add set extend operation #663

merged 1 commit into from
Jan 29, 2025

Conversation

domenic
Copy link
Member

@domenic domenic commented Jan 29, 2025 •
edited by pr-preview bot
Loading

"List extend" didn't really work since it used "list append", which doesn't properly handle duplicates.

Preview | Diff

@domenic
Add set extend operation
dda9b15 
"List extend" didn't really work since it used "list append", which doesn't properly handle duplicates.
@domenic domenic requested a review from annevk January 29, 2025 06:47
annevk
annevk approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprising that we already had prepend but not extend.

@domenic domenic merged commit 8c74b2a into main Jan 29, 2025
2 checks passed
@domenic domenic deleted the set-extend branch January 29, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domenic @annevk