GoalProof 도메인을 리팩터링합니다. #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkSpace
reviewed
Dec 9, 2023
Comment on lines
27
to
28
| @Column(name = "url") | ||
| val url: String, |
There was a problem hiding this comment.
이러면 Wrapper클래스가 아닌게 되어버려서 분리해야 하는거 아니에요?
차라리 url은 이전에 만들어둔 URL 사용하고 이것만 document 하는것도 나쁘지 않을듯 하네요
K-Diger
force-pushed
the
refactor/goal-proof
branch
from
7ace84e to
f645115
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
기존 GoalProof의 Column에는
document라고 지정된 컬럼만 존재했습니다.하지만 아래 디자인인에는 인증 사진과 첨언을 기록할 수 있도록 되어있어 컬럼을 추가합니다.