Merge pull request #93 from whatever-mentoring/feature/goal-gifticon-…

…controller-test

Write test codes of GoalGifticonController

raisedragon-api/src/main/kotlin/com/whatever/raisedragon/applicationservice/goalgifticon/GoalGifticonApplicationService.kt

@@ -8,10 +8,10 @@ import com.whatever.raisedragon.common.exception.BaseException
 import com.whatever.raisedragon.common.exception.ExceptionCode
 import com.whatever.raisedragon.domain.gifticon.GifticonService
 import com.whatever.raisedragon.domain.gifticon.URL
-import com.whatever.raisedragon.domain.goal.*
+import com.whatever.raisedragon.domain.goal.Goal
+import com.whatever.raisedragon.domain.goal.GoalService
+import com.whatever.raisedragon.domain.goal.GoalType
 import com.whatever.raisedragon.domain.goalgifticon.GoalGifticonService
-import com.whatever.raisedragon.domain.user.UserService
-import com.whatever.raisedragon.domain.user.fromDto
 import com.whatever.raisedragon.domain.winner.WinnerService
 import org.springframework.stereotype.Service
 import org.springframework.transaction.annotation.Transactional
@@ -23,7 +23,6 @@ class GoalGifticonApplicationService(
     private val gifticonService: GifticonService,
     private val goalService: GoalService,
     private val goalGifticonService: GoalGifticonService,
-    private val userService: UserService,
     private val winnerService: WinnerService
 ) {
 

raisedragon-api/src/main/kotlin/com/whatever/raisedragon/controller/goalgifticon/GoalGifticonController.kt

@@ -29,14 +29,13 @@ class GoalGifticonController(
     @PostMapping
     fun create(
         @GetAuth userInfo: UserInfo,
-        @Valid request: GoalGifticonCreateRequest,
+        @Valid @RequestBody request: GoalGifticonCreateRequest,
     ): Response<GoalGifticonResponse> {
         return Response.success(
             goalGifticonApplicationService.createAndUploadGifticon(request.toServiceRequest(userInfo.id))
         )
     }
 
-    @ResponseStatus(HttpStatus.CREATED)
     @Operation(
         summary = "다짐 내 기프티콘 조회 API",
         description = "다짐 내 기프티콘 조회 (나의 기프티콘 이거나 승리한 경우 조회 가능)",
@@ -52,7 +51,6 @@ class GoalGifticonController(
         )
     }
 
-    @ResponseStatus(HttpStatus.CREATED)
     @Operation(
         summary = "다짐 내 기프티콘 수정 API",
         description = "다짐 내 기프티콘 수정",

raisedragon-api/src/main/kotlin/com/whatever/raisedragon/controller/goalgifticon/GoalGifticonDto.kt

@@ -3,16 +3,13 @@ package com.whatever.raisedragon.controller.goalgifticon
 import com.whatever.raisedragon.applicationservice.goalgifticon.dto.GoalGifticonCreateServiceRequest
 import com.whatever.raisedragon.applicationservice.goalgifticon.dto.GoalGifticonUpdateServiceRequest
 import io.swagger.v3.oas.annotations.media.Schema
-import jakarta.validation.constraints.NotNull
 
 @Schema(description = "[Request] 다짐에 기프티콘 업로드")
 data class GoalGifticonCreateRequest(
     @Schema(description = "기프티콘을 등록할 다짐의 Id")
-    @field:NotNull
     val goalId: Long,
 
     @Schema(description = "기프티콘 URL")
-    @field:NotNull
     val gifticonURL: String
 )
 
@@ -27,11 +24,9 @@ fun GoalGifticonCreateRequest.toServiceRequest(
 @Schema(description = "[Request] 다짐 기프티콘 수정")
 data class GoalGifticonRequest(
     @Schema(description = "기프티콘을 등록할 다짐의 Id")
-    @field:NotNull
     val goalId: Long,
 
     @Schema(description = "기프티콘 URL")
-    @field:NotNull
     val gifticonURL: String
 )
 

raisedragon-api/src/test/kotlin/com/whatever/raisedragon/ControllerTestSupport.kt

@@ -2,17 +2,23 @@ package com.whatever.raisedragon
 
 import com.fasterxml.jackson.databind.ObjectMapper
 import com.whatever.raisedragon.applicationservice.betting.BettingApplicationService
+import com.whatever.raisedragon.applicationservice.goalgifticon.GoalGifticonApplicationService
 import com.whatever.raisedragon.controller.betting.BettingController
+import com.whatever.raisedragon.controller.goalgifticon.GoalGifticonController
 import org.mockito.Mockito.*
 import org.springframework.beans.factory.annotation.Autowired
 import org.springframework.boot.test.autoconfigure.web.servlet.WebMvcTest
 import org.springframework.boot.test.mock.mockito.MockBean
+import org.springframework.http.MediaType
+import org.springframework.security.test.web.servlet.request.SecurityMockMvcRequestPostProcessors
 import org.springframework.test.context.ActiveProfiles
 import org.springframework.test.web.servlet.MockMvc
+import org.springframework.test.web.servlet.request.MockHttpServletRequestBuilder
 
 @WebMvcTest(
     controllers = [
-        BettingController::class
+        BettingController::class,
+        GoalGifticonController::class,
     ]
 )
 @ActiveProfiles("test")
@@ -26,4 +32,19 @@ abstract class ControllerTestSupport {
 
     @MockBean
     protected lateinit var bettingApplicationService: BettingApplicationService
+
+    @MockBean
+    protected lateinit var goalGifticonApplicationService: GoalGifticonApplicationService
+
+    protected fun MockHttpServletRequestBuilder.withCsrf(): MockHttpServletRequestBuilder {
+        return with(SecurityMockMvcRequestPostProcessors.csrf())
+    }
+
+    protected fun MockHttpServletRequestBuilder.writeRequestAsContent(request: Any): MockHttpServletRequestBuilder {
+        return content(objectMapper.writeValueAsString(request))
+    }
+
+    protected fun MockHttpServletRequestBuilder.contentTypeAsJson(): MockHttpServletRequestBuilder {
+        return contentType(MediaType.APPLICATION_JSON)
+    }
 }

raisedragon-api/src/test/kotlin/com/whatever/raisedragon/controller/betting/BettingControllerTest.kt

@@ -9,8 +9,6 @@ import org.hamcrest.core.IsNull.nullValue
 import org.junit.jupiter.api.DisplayName
 import org.junit.jupiter.api.Test
 import org.mockito.Mockito.*
-import org.springframework.http.MediaType
-import org.springframework.security.test.web.servlet.request.SecurityMockMvcRequestPostProcessors.csrf
 import org.springframework.test.web.servlet.request.MockMvcRequestBuilders.*
 import org.springframework.test.web.servlet.result.MockMvcResultMatchers.jsonPath
 import org.springframework.test.web.servlet.result.MockMvcResultMatchers.status
@@ -28,9 +26,9 @@ class BettingControllerTest : ControllerTestSupport() {
         mockMvc
             .perform(
                 post("/v1/betting")
-                    .with(csrf())
-                    .content(objectMapper.writeValueAsString(request))
-                    .contentType(MediaType.APPLICATION_JSON)
+                    .withCsrf()
+                    .writeRequestAsContent(request)
+                    .contentTypeAsJson()
             )
             .andDo(::print)
             .andExpect(status().isCreated())
@@ -48,9 +46,9 @@ class BettingControllerTest : ControllerTestSupport() {
         mockMvc
             .perform(
                 post("/v1/betting")
-                    .with(csrf())
-                    .content(objectMapper.writeValueAsString(request))
-                    .contentType(MediaType.APPLICATION_JSON)
+                    .withCsrf()
+                    .writeRequestAsContent(request)
+                    .contentTypeAsJson()
             )
             .andDo(::print)
             .andExpect(status().isBadRequest)
@@ -87,9 +85,9 @@ class BettingControllerTest : ControllerTestSupport() {
         mockMvc
             .perform(
                 put("/v1/betting")
-                    .with(csrf())
-                    .content(objectMapper.writeValueAsString(request))
-                    .contentType(MediaType.APPLICATION_JSON)
+                    .withCsrf()
+                    .writeRequestAsContent(request)
+                    .contentTypeAsJson()
             )
             .andDo(::print)
             .andExpect(status().isOk)

raisedragon-api/src/test/kotlin/com/whatever/raisedragon/controller/goalgifticon/GoalGifticonControllerTest.kt

@@ -0,0 +1,74 @@
+package com.whatever.raisedragon.controller.goalgifticon
+
+import com.whatever.raisedragon.ControllerTestSupport
+import com.whatever.raisedragon.security.WithCustomUser
+import org.hamcrest.core.IsNull.nullValue
+import org.junit.jupiter.api.Assertions.*
+import org.junit.jupiter.api.DisplayName
+import org.junit.jupiter.api.Test
+import org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get
+import org.springframework.test.web.servlet.request.MockMvcRequestBuilders.post
+import org.springframework.test.web.servlet.result.MockMvcResultMatchers.jsonPath
+import org.springframework.test.web.servlet.result.MockMvcResultMatchers.status
+
+@WithCustomUser(id = 1L, nickname = "User")
+class GoalGifticonControllerTest : ControllerTestSupport() {
+
+    @DisplayName("GoalGifticon을 생성한다.")
+    @Test
+    fun create() {
+        // given
+        val gifticonUrl = "www.sample.com/gifticon"
+        val request = GoalGifticonCreateRequest(goalId = 1L, gifticonURL = gifticonUrl)
+
+        // when // then
+        mockMvc
+            .perform(
+                post("/v1/goal-gifticon")
+                    .withCsrf()
+                    .writeRequestAsContent(request)
+                    .contentTypeAsJson()
+            )
+            .andDo(::print)
+            .andExpect(status().isCreated)
+            .andExpect(jsonPath("$.isSuccess").value(true))
+            .andExpect(jsonPath("$.errorResponse").value(nullValue()))
+    }
+
+    @DisplayName("다짐 내 GoalGifticon을 조회한다.")
+    @Test
+    fun retrieve() {
+        // given
+        val goalId = 1L
+
+        // when // then
+        mockMvc
+            .perform(
+                get("/v1/goal-gifticon/$goalId")
+            )
+            .andDo(::print)
+            .andExpect(status().isOk)
+            .andExpect(jsonPath("$.isSuccess").value(true))
+            .andExpect(jsonPath("$.errorResponse").value(nullValue()))
+    }
+
+    @DisplayName("다짐 내 기프티콘을 수정한다.")
+    @Test
+    fun update() {
+        // given
+        val gifticonUrl = "www.sample.com/updated-gifticon"
+        val request = GoalGifticonRequest(goalId = 1L, gifticonURL = gifticonUrl)
+
+        // when // then
+        mockMvc
+            .perform(
+                post("/v1/goal-gifticon")
+                    .withCsrf()
+                    .writeRequestAsContent(request)
+                    .contentTypeAsJson()
+            )
+            .andDo(::print)
+            .andExpect(jsonPath("$.isSuccess").value(true))
+            .andExpect(jsonPath("$.errorResponse").value(nullValue()))
+    }
+}