Code

Feature/streaming fix windows#128

Code

Closed

gessulat wants to merge 27 commits intowfondrie:mainwfondrie/mokapot:mainfrom msaid-de:feature/streaming-fix-windowsmsaid-de/mokapot:feature/streaming-fix-windowsCopy head branch name to clipboard

+7,691-4,207

Commits

Commits on Sep 19, 2024

• ✨ cherry picks internal fixes from !68 and !70

  gessulat

  committed
  c82b1e0

  Copy full SHA for c82b1e0

Commits on Sep 27, 2024

• Cherry pick feature/confidence_streaming branch

  ezander

  committed
  08d7c3f

  Copy full SHA for 08d7c3f

• ✨ adds filelock dependency for tests

  gessulat

  committed
  92f9e9a

  Copy full SHA for 92f9e9a

• 💄 linting

  gessulat

  committed
  18f8dca

  Copy full SHA for 18f8dca

• 💄 reformat to satisfy linter

  Show description for ab54bba
  gessulat

  committed
  ab54bba

  Copy full SHA for ab54bba

• ✨ imports type annotations from future for python 3.9

  gessulat

  committed
  a000faf

  Copy full SHA for a000faf

• ✨ make pytest and cli behave with type annotations in Python 3.9

  gessulat

  committed
  3ff7410

  Copy full SHA for 3ff7410

• ✨ test dropping Python 3.9 support

  Show description for 6aaf5b0
  gessulat

  committed
  6aaf5b0

  Copy full SHA for 6aaf5b0

Commits on Oct 1, 2024

• Set scale_to_one to false in *all* cases

  ezander

  committed
  11967f7

  Copy full SHA for 11967f7

• Fixed path problems probably causing errors under windows

  ezander

  committed
  930a50a

  Copy full SHA for 930a50a

• Fix more possible path issues

  ezander

  committed
  6c646a2

  Copy full SHA for 6c646a2

• Fix warning about bitwise not in python 3.12

  ezander

  committed
  fd033ee

  Copy full SHA for fd033ee

Commits on Oct 3, 2024

• Fix problem with numpy 2.x's different str rep of floats

  ezander

  committed
  02d4c21

  Copy full SHA for 02d4c21

• Make hashing of rows for splitting independent of numpy version and spectra columns

  ezander

  committed
  7f58137

  Copy full SHA for 7f58137

Commits on Oct 8, 2024

• ✨ investigate what scores does in windows

  gessulat

  committed
  10b5739

  Copy full SHA for 10b5739

• ✨ only test failing test to speed up feedback loop

  gessulat

  committed
  40fde9b

  Copy full SHA for 40fde9b

• ✨ are scores zero?

  gessulat

  committed
  f11693e

  Copy full SHA for f11693e

• ✨ why does training fail (silently?)

  gessulat

  committed
  78548ff

  Copy full SHA for 78548ff

• ✨ we're failing in fold 1. what is in fold 1? why is it different in

  Show description for 894a10c
  gessulat

  committed
  894a10c

  Copy full SHA for 894a10c

• ✨ set logger to debug; describe into column that leads to bad training

  gessulat

  committed
  c6089be

  Copy full SHA for c6089be

• ✨ we fail in ubuntu so that we can compare debug logs

  gessulat

  committed
  893b45f

  Copy full SHA for 893b45f

• ✨ log more infos during training

  gessulat

  committed
  efe1018

  Copy full SHA for efe1018

• ✨ fix messed up logging

  gessulat

  committed
  a4d04d0

  Copy full SHA for a4d04d0

Commits on Oct 9, 2024

• ✨ uses uv for env setup; fix dependencies

  gessulat

  committed
  90d9cb9

  Copy full SHA for 90d9cb9

• ✨ do we need to run the subprocess via uv explicitly for Windows?

  gessulat

  committed
  5848f24

  Copy full SHA for 5848f24

• ✨ role back added logs

  gessulat

  committed
  b80b90f

  Copy full SHA for b80b90f

• ☂️ re-enable tests

  gessulat

  committed
  2d4d438

  Copy full SHA for 2d4d438