-
-
Notifications
You must be signed in to change notification settings - Fork 935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move configuration, script and contract files into dedicated dev folder #460
Conversation
@Raiden1411 is attempting to deploy a commit to the wagmi Team on Vercel. A member of the Team first needs to authorize it. |
|
Codecov Report
@@ Coverage Diff @@
## main #460 +/- ##
==========================================
- Coverage 99.92% 96.13% -3.80%
==========================================
Files 254 236 -18
Lines 23688 20823 -2865
Branches 1968 1661 -307
==========================================
- Hits 23671 20018 -3653
- Misses 17 800 +783
- Partials 0 5 +5 |
The changeset bot currently is not able to look other than the root folder for the changeset. Not sure if the PR that fixes that will land. |
Mhm, I can see that However, I am not sure if I like inventing a bunch of crafty tricks & maintaining those and going against the flow with this. Coming to this repository as a new contributor I'd likely find it harder to navigate things & find which config is coming from where if it's hidden in an unexpected location. Now, for the status quo to change and the community eventually settling on a shared config location someone has to be the first mover... Not sure if I'd want us to do that tbh. :-/ |
Generally agree with @fubhy. I like to be more pragmatic with directory structure, etc. Config at the root may look overloaded, but it is most discoverable there. |
Agree with all these points. Hope it's better supported someday or tools have sensible enough defaults so you don't need to configure them :) |
PR-Codex overview
This PR updates and moves config files into a dedicated
dev
directory. Notable changes include:dev
directory with updated file paths.vscode
and.idea
directoriescache
andout
directorieslib/ds-test
submoduleCompilationTest
,CompilationScript
, andStdError