Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump template to v2024.29 #136

Merged
merged 14 commits into from
Oct 10, 2024
Merged

bump template to v2024.29 #136

merged 14 commits into from
Oct 10, 2024

Conversation

joshuadavidthomas
Copy link
Member

closes #120

@joshuadavidthomas joshuadavidthomas requested review from a team as code owners October 10, 2024 20:06
README.md Outdated
## Requirements

- Python 3.9, 3.10, 3.11, 3.12, 3.13
- Python 3.8, 3.9, 3.10, 3.11, 3.12, 3.13
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you have second thoughts on dumping 3.8? (I think it can be a soft drop where we don't go out of our way to prevent it working on 3.8)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm not going out of my way to prevent it working, but I'm publicly dropping support the minute a version goes on this list: https://devguide.python.org/versions/#unsupported-versions.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though now that I think through it, maybe Django should be the driver of that -- and 3.8 is still supported under 4.2 https://docs.djangoproject.com/en/dev/faq/install/#what-python-version-can-i-use-with-django.

I could go either way I guess, not sure what the right decision is.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I'm going to leave it alone for now and stick to if Django supports it, we'll support it as long as we aren't using a feature of Python not available in it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh... I see what you were asking now 🤦‍♂️

No, the copier update wiped away the README and I reverted it to the one on main and missed that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

giphy

EH, in light of that, dropping 3.8 seems fine.. What a wild ride.

@joshuadavidthomas joshuadavidthomas merged commit 0ae72c8 into main Oct 10, 2024
23 checks passed
@joshuadavidthomas joshuadavidthomas deleted the bump-template branch October 10, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump django-twc-package to v2024.29
2 participants