-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump template to v2024.29 #136
Conversation
for more information, see https://pre-commit.ci
README.md
Outdated
## Requirements | ||
|
||
- Python 3.9, 3.10, 3.11, 3.12, 3.13 | ||
- Python 3.8, 3.9, 3.10, 3.11, 3.12, 3.13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you have second thoughts on dumping 3.8? (I think it can be a soft drop where we don't go out of our way to prevent it working on 3.8)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'm not going out of my way to prevent it working, but I'm publicly dropping support the minute a version goes on this list: https://devguide.python.org/versions/#unsupported-versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though now that I think through it, maybe Django should be the driver of that -- and 3.8 is still supported under 4.2 https://docs.djangoproject.com/en/dev/faq/install/#what-python-version-can-i-use-with-django.
I could go either way I guess, not sure what the right decision is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I'm going to leave it alone for now and stick to if Django supports it, we'll support it as long as we aren't using a feature of Python not available in it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh... I see what you were asking now 🤦♂️
No, the copier update wiped away the README and I reverted it to the one on main
and missed that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
closes #120