feat: Use Cert Manager to Create Certificates for News Aggregator Server #15
Conversation
werniq
changed the title
werniq
changed the base branch from
feature/migrate-to-taskfile
to
feature/helm
Changed base branch |
cmd/server/certs/tls.crt
Outdated
| @@ -0,0 +1,10 @@ | |||
| -----BEGIN CERTIFICATE----- | |||
There was a problem hiding this comment.
so if you are using cert-manager there is no need to push certs anymore, they can be created dynamically using cert-manager
pls integrate that
cmd/server/start_server.go
Outdated
| @@ -91,10 +112,69 @@ func ConfAndRun() error { | |||
|
|
|||
| setupRoutes(server) | |||
|
|
|||
| c := config.GetConfigOrDie() | |||
There was a problem hiding this comment.
news-aggregator is just a pure https server, it should not care about certs
it should read certs from the file system
you can attach certs generated by k8s to the file system of news-aggregator
cmd/server/start_server.go
Outdated
| } | ||
|
|
||
| // loadCertsFromSecrets loads certificates from Kubernetes secrets | ||
| func loadCertsFromSecrets() (string, string, error) { |
There was a problem hiding this comment.
pls check my comment above, this should not be there
operator/Makefile
Outdated
There was a problem hiding this comment.
??
i think we get rid of makefile
There was a problem hiding this comment.
Pulled data from prev PRs. Deleted
operator/Taskfile.yml
Outdated
| @@ -1,252 +1,158 @@ | |||
| version: '3' | |||
|
|
|||
There was a problem hiding this comment.
why changed again ?
There was a problem hiding this comment.
I haven't changed, I've just have not pulled data from prev PR's. Resolved
templates/_self_signed_ca_issuer.yml
Outdated
There was a problem hiding this comment.
should be under helm chart right?
+ integrate helm values
There was a problem hiding this comment.
Added values for issuer and secrets in helm
…o feature/cert-manager
| @@ -4,9 +4,3 @@ description: A Helm chart for Kubernetes | |||
| type: application | |||
| version: 0.1.0 | |||
| appVersion: "1.16.0" | |||
| dependencies: | |||
There was a problem hiding this comment.
Wrong branch, added dependencies
| - server auth | ||
| - client auth | ||
| dnsNames: | ||
| - "go-gator-server" |
There was a problem hiding this comment.
do you have such dns name?
There was a problem hiding this comment.
It is creating without dnsNames, removed.
There was a problem hiding this comment.
I want you to put a dns name which you use. not just removing it.
what dns name do you use?
go-gator/templates/cert_secret.yaml
Outdated
| @@ -0,0 +1,5 @@ | |||
| apiVersion: v1 | |||
There was a problem hiding this comment.
the secret will be created automatically by certificate CR (cert-manager)
There was a problem hiding this comment.
But how do we assign it to the deployment? It will add random sequence of letters after cert name
There was a problem hiding this comment.
you can specify secret name in the cert itself
There was a problem hiding this comment.
I tried to reproduce this without secret, but:
It is not creating the secret with exactly same name from values.
| @@ -0,0 +1,17 @@ | |||
| apiVersion: cert-manager.io/v1 | |||
There was a problem hiding this comment.
why do you need that cert? how is this used? I see you have almost similar below.
templates/0_namespace.yml
Outdated
There was a problem hiding this comment.
templates folder can be completely removed since you moved to helm charts
There was a problem hiding this comment.
Removed in helm PR, to avoid duplication
|
Working fine: |
go.mod
Outdated
| @@ -8,41 +8,89 @@ require ( | |||
| github.com/PuerkitoBio/goquery v1.9.2 | |||
| github.com/gin-gonic/gin v1.10.0 | |||
| github.com/jarcoal/httpmock v1.3.1 | |||
| github.com/spf13/cobra v1.8.0 | |||
| github.com/spf13/cobra v1.8.1 | |||
There was a problem hiding this comment.
I'm not sure from where this changes are, but I will revert to previous version
Introduce Certificate Generation using Helm Chart of Cert-Manager
Summary
This pull request introduces the implementation of certificate generation and management using Cert-Manager.
The main focus is on integrating certificate creation and retrieval within our news aggregator, using Kubernetes' Golang client to manage and apply the certificates dynamically when running the server.
Key Changes
Certificate Resource Creation:
Secret Management:
defaultSecretName.Certificate and Key Handling:
defaultCertNameanddefaultPrivateKey, they are retrieved from secret, generated bycert-manager.Server Configuration: