other way? #74
Open
other way? #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Bootstrap support
Reduced use of wrapper when not needed Added resize event to reposition
Positioning, Reduced wrapper, Updated demo
triggers keyup event after emoji input for event binding
For/in, at least in our environment, winds up iterating over the object's prototype methods such as `_super` and `nextObject`. These result in a _bunch_ of `class="emoji-undefined"` elements being added to the UI which makes the sections scroll way farther than needed. Switching for/in to a normal for loop because these are just arrays so why bother with for/in and hasOwnProperty?
Use normal for loop instead of for/in
…cker into pickerUpdates
Picker updates
Return better name of plugin instance. 🐸
Adds onShow/onHide handlers 🍹
Destroy an emoji picker instance.
Fire an actual change event on emoji input
If you clicked on the grey background color area of a particular emoji and not the emoji itself, the wrong emoji would be spit out on the screen. Code I added makes sure that the right emoji is written out.
Checks for mobile before calling destroy()
Fix a bug related to clicking on emojis
remove green
adding in the picker functionality like the click and the search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.