Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don's ajust audio track if there is no audio track #1691

Merged
merged 3 commits into from
Jan 4, 2025

Conversation

StaZhu
Copy link
Contributor

@StaZhu StaZhu commented Dec 25, 2024

On a M4 Mac Mini, there is no built-in microphone or camera, so getAudioTracks() will always return an empty array. In this case, we don't need to ajust sampling rate to 48khz...

Also change av1 codecs string from av01.1.x.y to av01.0.x.y since MediaRecorder only support av1 main profile instead of high profile.

@alvestrand
Copy link
Contributor

Looks straightforward, but makes the relevant selenium test fail (see bot logs). Please investigate, and fix if possible.

@StaZhu
Copy link
Contributor Author

StaZhu commented Dec 31, 2024


> [email protected] jest
> node test/download-browsers.js && jest --testTimeout 5000 --maxWorkers=1 src/content/ --retries=3

/home/runner/work/samples/samples/node_modules/selenium-webdriver/lib/error.js:521
    let err = new ctor(data.message)
              ^

SessionNotCreatedError: session not created: Chrome failed to start: exited normally.
  (session not created: DevToolsActivePort file doesn't exist)
  (The process started from chrome location /home/runner/work/samples/samples/browsers/chrome/linux-131.0.6778.204/chrome-linux64/chrome is no longer running, so ChromeDriver is assuming that Chrome has crashed.)

It seems the failure not related to the change, could you help re-trigger the CI? Thanks

On a M4 Mac Mini, there is no built-in microphone or
camera, so `getAudioTracks()` will always return an
empty array. In this case, we don't need to ajust
sampling rate to 48khz...

Also change av1 codecs string from `av01.1.x.y` to
`av01.0.x.y` since MediaRecorder only support av1
main profile instead of high profile.
@StaZhu
Copy link
Contributor Author

StaZhu commented Jan 3, 2025

Hi @alvestrand, is it possible to skip the CI, I run the CI locally and don't have any issue.

@StaZhu
Copy link
Contributor Author

StaZhu commented Jan 3, 2025

@handellm Could you help take a look markus? Seems like you previous merge request also has similar CI issue.

@alvestrand
Copy link
Contributor

@fippo found an error that might have been the reason why this workflow failed. Will approve once the test passes.

@fippo
Copy link
Collaborator

fippo commented Jan 3, 2025

Still picking up the wrong CI image it seems ... lets try again tomorrow and if it still does not merge ignore the failure

@StaZhu
Copy link
Contributor Author

StaZhu commented Jan 4, 2025

Thanks!

@alvestrand alvestrand merged commit 65f8969 into webrtc:gh-pages Jan 4, 2025
3 checks passed
@alvestrand
Copy link
Contributor

Merging, as the latest fix to the CI config seems to have fixed the issue.
Thanks for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants