-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don's ajust audio track if there is no audio track #1691
Conversation
Looks straightforward, but makes the relevant selenium test fail (see bot logs). Please investigate, and fix if possible. |
It seems the failure not related to the change, could you help re-trigger the CI? Thanks |
On a M4 Mac Mini, there is no built-in microphone or camera, so `getAudioTracks()` will always return an empty array. In this case, we don't need to ajust sampling rate to 48khz... Also change av1 codecs string from `av01.1.x.y` to `av01.0.x.y` since MediaRecorder only support av1 main profile instead of high profile.
Hi @alvestrand, is it possible to skip the CI, I run the CI locally and don't have any issue. |
@handellm Could you help take a look markus? Seems like you previous merge request also has similar CI issue. |
@fippo found an error that might have been the reason why this workflow failed. Will approve once the test passes. |
Still picking up the wrong CI image it seems ... lets try again tomorrow and if it still does not merge ignore the failure |
Thanks! |
Merging, as the latest fix to the CI config seems to have fixed the issue. |
On a M4 Mac Mini, there is no built-in microphone or camera, so
getAudioTracks()
will always return an empty array. In this case, we don't need to ajust sampling rate to 48khz...Also change av1 codecs string from
av01.1.x.y
toav01.0.x.y
since MediaRecorder only support av1 main profile instead of high profile.