facebook fix + configurable storage/cookie archiving #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The settings in the Preferences tab don't seem to actually save/stick, so I'm unable to test this. Steps to reproduce:
|
bump to wabac 2.20.5
|
@tw4l Should be fixed now! Somehow missed in switch to using abstracted localStorage (either extension specific or regular in app) |
tw4l
reviewed
Nov 20, 2024
src/ui/app.ts
Outdated
Comment on lines
113
to
116
| if (archiveCookies === null) { | ||
| await setLocalOption("archiveCookies", "1"); | ||
| this.archiveCookies = true; | ||
| } |
There was a problem hiding this comment.
Might need to add another if statement here to set this.archiveCookies to true if archiveCookies === "1" or false if it's "0"? It doesn't seem to be persisting currently if I leave the settings page (e.g. to view an archived item) and then come back.
tw4l
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support for configurable cookie / storage archiving, from UI settings from #276
fix for facebook archiving + replay using dash rewriting + range-from-query replay via wabac.js 2.20.4
fixes #272, #273