This repository has been archived by the owner on Mar 16, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 44
refactor(plugin): v1.0.0 #70
Open
joshwiens
wants to merge
3
commits into
master
Choose a base branch
from
next
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
====================================
Coverage 84% 84%
====================================
Files 2 2
Lines 50 50
Branches 17 17
====================================
Hits 42 42
Misses 8 8 Continue to review full report at Codecov.
|
joshwiens
changed the title
[WIP] Babel Minify Plugin v1
refactor: Babel Minify Plugin Webpack 4.x compatibility
Dec 5, 2017
8 tasks
- Upgrades to `[email protected]` - Drops support for `node =< v4.0.0` - Sets the minimum `peerDependency` to `webpack >= 3.0.0` BREAKING CHANGE: Sets `engines` to `"node": ">= 6.9.0 || >= 8.9.0"` BREAKING CHANGE: Drops support for `webpack =< v2.0.0`
@@ -0,0 +1,9 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{
"type": "object",
"properties": {
"parserOpts": {
"type": "object"
},
"babel": {
"typeof": "function"
},
"minifyPreset": {
"typeof": "function"
},
"comments": {
"instanceof": "RegExp"
},
"sourceMap": {
"type": "boolean"
}
},
"additionalProperties": false
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But better with tests 😛
michael-ciniawsky
changed the title
refactor: Babel Minify Plugin Webpack 4.x compatibility
refactor: webpack 4.x compatibility
Dec 21, 2017
michael-ciniawsky
changed the title
refactor: webpack 4.x compatibility
refactor(plugin): v1.0.0
Mar 19, 2018
Hello, thx for the great work on this PR. Any plans on when it will be merged? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[email protected]
BREAKING CHANGE: Sets
engines
to"node": ">= 6.9.0 || >= 8.9.0"
BREAKING CHANGE: Drops support for Webpack
v2.x
BREAKING CHANGE: Incorrect configuration options will now throw