Fix to drop checking disk space on every tick

webmin · Jun 26, 2024 · f4b47c9 · f4b47c9
1 parent 4e59886
commit f4b47c9
Show file tree

Hide file tree

Showing 7 changed files with 2 additions and 29 deletions.
diff --git a/lang/en b/lang/en
@@ -786,8 +786,6 @@ theme_xhred_nice_size_GB=GB
 theme_xhred_nice_size_MB=MB
 theme_xhred_nice_size_kB=kB
 theme_xhred_nice_size_b=bytes
-settings_sysinfo_real_time_status_disk=Enable for disks
-settings_sysinfo_real_time_status_disk_description=It might be useful to disable real-time monitoring for disks on slow/large file systems
 theme_xhred_title_locale_non_ui_config=Server generated date format
 
 

diff --git a/stats-lib.pl b/stats-lib.pl
@@ -195,28 +195,6 @@ sub stats
         }
     }
 
-    # Disk space
-    if (acl_system_status('disk')) {
-        if (foreign_check("mount") && get_stats_option('status_disk')) {
-            foreign_require("mount");
-
-            my @disk_space = defined(&mount::local_disk_space) ? mount::local_disk_space() : ();
-            if (@disk_space) {
-                $data{'disk'} = [];
-
-                if (@disk_space && $disk_space[0] && $disk_space[0] > 0) {
-                    my $disk = int(($disk_space[0] - $disk_space[1]) / $disk_space[0] * 100);
-                    $data{'disk'} = [$disk,
-                                        text('body_used_and_free',
-                                            nice_size($disk_space[0]),
-                                            nice_size($disk_space[1]),
-                                            nice_size($disk_space[0] - $disk_space[1])
-                                        )];
-                }
-            }
-        }
-    }
-
     # Network I/O
     if (acl_system_status('load')) {
         my $network = network_stats('io');

diff --git a/tconfig-lib.pl b/tconfig-lib.pl
@@ -49,7 +49,6 @@ sub theme_settings_raw
                        'settings_sysinfo_hidden_panels_user',
                        'settings_sysinfo_max_servers',
                        'settings_sysinfo_real_time_status',
-                       'settings_sysinfo_real_time_status_disk',
                        'settings_sysinfo_real_time_stored',
             ] }
         ],
@@ -256,7 +255,6 @@ sub theme_settings_filter
              'settings_sysinfo_easypie_charts_scale',
              'settings_sysinfo_max_servers',
              'settings_sysinfo_real_time_status',
-             'settings_sysinfo_real_time_status_disk',
              'settings_sysinfo_real_time_stored',
              'settings_leftmenu_section_hide_refresh_modules',
              'settings_leftmenu_section_hide_unused_modules',

diff --git a/theme.info b/theme.info
@@ -4,7 +4,7 @@ bootstrap=3
 spa=1
 nomodcall=xnavigation=1
 version=21.20-RC2
-mversion=02
+mversion=03
 bversion=00
 webmin=1
 usermin=1

diff --git a/unauthenticated/js/bundle.min.js b/unauthenticated/js/bundle.min.js
diff --git a/unauthenticated/js/bundle.min.js.gz b/unauthenticated/js/bundle.min.js.gz
diff --git a/unauthenticated/js/defaults.js b/unauthenticated/js/defaults.js
@@ -20,7 +20,6 @@ var
     settings_sysinfo_easypie_charts_scale = 10,
     settings_sysinfo_max_servers = 10,
     settings_sysinfo_real_time_status = 1,
-    settings_sysinfo_real_time_status_disk = true,
     settings_sysinfo_real_time_stored = true,
     settings_sysinfo_real_time_stored_duration = 600,