-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(app-aco): introduce Folders features #4512
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eo/refactor/app-aco-fta
# Conflicts: # packages/app-aco/src/components/FolderTree/List/index.tsx # packages/app-file-manager/src/modules/FileManagerRenderer/FileManagerViewProvider/useListFiles.ts # yarn.lock
We're moving forward with #4513 instead! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR introduces a significant structural reorganization of the
app-aco
package by refactoringfolders
logic into a new feature-based architecture. The goal is to improve modularity, maintainability, and scalability by moving away from React Context and feature hooks (useFolders
) in favor of self-contained feature modules.1. Introduction of Feature-Based Architecture
useCreateFolder()
).createFolder
, etc.), making it explicit and easy to use.2. New Feature Structure
The feature modules follow a clean separation of concerns:
3. Backward Compatibility
useFolders
hook and its methods remain available but are now deprecated.useFolders
hook in other packages have been replaced with their respective feature-specific hooks (e.g.,useCreateFolder()
).How Has This Been Tested?
Jest + manually