[BUGFIX] Make custom DataHandler command in select boxes work #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koehnlein
force-pushed
the
bugfix-translate-by-select
branch
from
96a0899 to
fad1e76
Compare
koehnlein
changed the title
In commit 0d4bc00 a custom DataHandler command was introduced for DeepL translations. This bugfix updates the "Translate with DeepL" select boxes in page module and list module to create translation records of pages.
koehnlein
force-pushed
the
bugfix-translate-by-select
branch
from
fad1e76 to
bee56b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #428
I am not completely happy with the
f:replacesolution. But it worked for me. Feel free to consider this as a draft and create a more beautiful solution. 🙂