[!!!][TASK] Mitigate depecated flash message severity #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since TYPO3 v12 the flash message severity are deprecated in favour of the `ContextualFeedbackSeverity` and will fail in TYPO3 v13. This change mitigates the deprecation and removal by directly using the native PHP Enum for TYPO3 v12 and TYPO3 v13 by: * Changing signature of `AbstractTranslateHook::flashMessages()` from integer to `ContextualFeedbackSeverity`. * Replace integer `-1` with `ContextualFeedbackSeverity::INFO` in two places within `TranslateHook`. Something addon extensions needs to handle on their own. [1] https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/12.0/Deprecation-97787-SeveritiesOfFlashMessagesAndReportsDeprecated.html
NarkNiro
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since TYPO3 v12 the flash message severity are deprecated in favour of
the
ContextualFeedbackSeverityand will fail in TYPO3 v13.This change mitigates the deprecation and removal by directly using the
native PHP Enum for TYPO3 v12 and TYPO3 v13 by:
AbstractTranslateHook::flashMessages()frominteger to
ContextualFeedbackSeverity.-1withContextualFeedbackSeverity::INFOin twoplaces within
TranslateHook. Something addon extensions needs tohandle on their own.
[1] https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/12.0/Deprecation-97787-SeveritiesOfFlashMessagesAndReportsDeprecated.html