Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SVG deprecated as discouraged feature #2485

Merged
merged 7 commits into from
Jan 7, 2025

Conversation

jamesnw
Copy link
Collaborator

@jamesnw jamesnw commented Dec 20, 2024

No description provided.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Dec 20, 2024
Copy link
Collaborator Author

@jamesnw jamesnw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

features/ping.yml Outdated Show resolved Hide resolved
name: svg-deprecated
description: Placeholder for deprecated or non-real features
name: SVG (deprecated)
description: SVG 2 deprecated or removed a significant number of features defined in SVG 1.1, including features related to fonts, alternate glyphs, the `xlink` namespace, and the `<cursor>` and `<tref>` elements.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a bit difficult to write, as this is a junk drawer feature, and its entire purpose for existing is to describe that deprecations occurred, and not the features themselves.

spec: https://svgwg.org/svg2-draft/
discouraged:
according_to:
- https://svgwg.org/svg2-draft/changes.html#substantial
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than link to the individual parts that deprecate each feature, this link enumerates them for us.

@@ -428,7 +428,6 @@ compat_features:
- svg.elements.script
- svg.elements.script.href
- svg.elements.script.type
- svg.elements.script.xlink_href
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be marked as deprecated in mdn/browser-compat-data#25477, but that doesn't block this change.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be resolved in #2500

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @jamesnw. I'm not sure how much (if any) time you'll be spending on this stuff in this calendar year, so I've made some suggestions. It looks like I'll catch up with you tomorrow and we can make a plan for handling the follow up work here.

features/svg-deprecated.yml Outdated Show resolved Hide resolved
features/ping.yml Outdated Show resolved Hide resolved
features/svg-deprecated.yml Outdated Show resolved Hide resolved
features/svg-deprecated.yml Outdated Show resolved Hide resolved
@jamesnw jamesnw requested a review from ddbeck January 6, 2025 18:55
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jamesnw!

@ddbeck ddbeck merged commit 06a9bed into web-platform-dx:main Jan 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants