-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SVG deprecated as discouraged feature #2485
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional context- https://github.com/w3c/svgwg/wiki/SVG-2-new-features#removed
features/svg-deprecated.yml
Outdated
name: svg-deprecated | ||
description: Placeholder for deprecated or non-real features | ||
name: SVG (deprecated) | ||
description: SVG 2 deprecated or removed a significant number of features defined in SVG 1.1, including features related to fonts, alternate glyphs, the `xlink` namespace, and the `<cursor>` and `<tref>` elements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a bit difficult to write, as this is a junk drawer feature, and its entire purpose for existing is to describe that deprecations occurred, and not the features themselves.
features/svg-deprecated.yml
Outdated
spec: https://svgwg.org/svg2-draft/ | ||
discouraged: | ||
according_to: | ||
- https://svgwg.org/svg2-draft/changes.html#substantial |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than link to the individual parts that deprecate each feature, this link enumerates them for us.
@@ -428,7 +428,6 @@ compat_features: | |||
- svg.elements.script | |||
- svg.elements.script.href | |||
- svg.elements.script.type | |||
- svg.elements.script.xlink_href |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be marked as deprecated in mdn/browser-compat-data#25477, but that doesn't block this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be resolved in #2500
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @jamesnw. I'm not sure how much (if any) time you'll be spending on this stuff in this calendar year, so I've made some suggestions. It looks like I'll catch up with you tomorrow and we can make a plan for handling the follow up work here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @jamesnw!
No description provided.