Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in file name #2484

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix typo in file name #2484

wants to merge 2 commits into from

Conversation

szepeviktor
Copy link
Contributor

Found this newest typo.

@ddbeck Please consider including typos in CI.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Dec 20, 2024
@szepeviktor
Copy link
Contributor Author

@ddbeck Could you lend me a click here?

@captainbrosset
Copy link
Contributor

Thank you for catching this and fixing it.
@ddbeck this is an ID change, so therefore a breaking change.
It would been good to catch this at pre-commit hook time. Something to consider adding for new features.

@captainbrosset captainbrosset requested a review from ddbeck January 7, 2025 13:06
@szepeviktor
Copy link
Contributor Author

#1825 is rather old 🤔

@ddbeck ddbeck added the major version required This PR requires a minor version semver release (vX+1.0.0) label Jan 9, 2025
@ddbeck ddbeck mentioned this pull request Jan 16, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddbeck ddbeck Awaiting requested review from ddbeck

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
feature definition Creating or defining new features or groups of features. major version required This PR requires a minor version semver release (vX+1.0.0)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@szepeviktor @captainbrosset @ddbeck