Skip to content

Commit

Permalink
Make the spec draft updater remove completed specs and work around nu…
Browse files Browse the repository at this point in the history
…lls (#1571)

And update dist, which was overlooked. These changes together will allow
the workflow to send PRs that pass the CI.
  • Loading branch information
foolip authored Aug 9, 2024
1 parent 97814f6 commit 82a157e
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/update_draft_features_weekly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ jobs:
node-version-file: .node-version
cache: npm
- run: npm ci
- run: rm features/draft/spec/*.yml features/draft/spec/*.dist
- run: npm run update-drafts
- run: npm run dist
- name: Commit changes
run: |
git config --local user.email "[email protected]"
Expand Down
7 changes: 7 additions & 0 deletions scripts/update-drafts.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,13 @@ async function main() {
continue;
}

// A few null values remain in BCD. They are being removed in
// https://github.com/mdn/browser-compat-data/pull/23774.
// TODO: Remove this workaround when BCD is free or true/null values.
if (feature.id.startsWith("html.manifest.")) {
continue;
}

const spec_url = feature.data.__compat.spec_url;
if (!spec_url) {
continue;
Expand Down

0 comments on commit 82a157e

Please sign in to comment.