Skip to content

Commit

Permalink
fix: include versions in error message for version mismatch (#8899)
Browse files Browse the repository at this point in the history
* fix: include versions in error message for version mismatch

* Update packages/rspack/src/util/bindingVersionCheck.ts

---------

Co-authored-by: neverland <[email protected]>
  • Loading branch information
haocheng6 and chenjiahan authored Jan 3, 2025
1 parent 3f5fc65 commit c5d582e
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions packages/rspack/src/util/bindingVersionCheck.ts
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,7 @@ export const checkVersion = () => {

if (!isMatch) {
return (result = new Error(
"Unmatched version @rspack/core@${CORE_VERSION}, @rspack/binding@${BINDING_VERSION}, @rspack/binding-${platformArchAbi}@${ADDON_VERSION}.\n" +
"Rspack requires these versions to be the same or you may have installed the wrong version. Otherwise, rspack may not work properly."
`Unmatched version @rspack/core@${CORE_VERSION}, @rspack/binding@${BINDING_VERSION}, @rspack/binding-${platformArchAbi}@${ADDON_VERSION}.\nRspack requires these versions to be the same or you may have installed the wrong version. Otherwise, Rspack may not work properly.`
));
}

Expand Down

1 comment on commit c5d582e

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented on c5d582e Jan 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Benchmark detail: Open

Name Base (2025-01-03 649c656) Current Change
10000_big_production-mode_disable-minimize + exec 37.6 s ± 265 ms 37.9 s ± 605 ms +0.99 %
10000_development-mode + exec 1.89 s ± 24 ms 1.81 s ± 43 ms -4.11 %
10000_development-mode_hmr + exec 677 ms ± 14 ms 673 ms ± 6.7 ms -0.56 %
10000_production-mode + exec 2.52 s ± 76 ms 2.43 s ± 36 ms -3.59 %
arco-pro_development-mode + exec 1.74 s ± 81 ms 1.7 s ± 48 ms -2.00 %
arco-pro_development-mode_hmr + exec 377 ms ± 1.5 ms 376 ms ± 1.2 ms -0.13 %
arco-pro_production-mode + exec 3.64 s ± 80 ms 3.53 s ± 69 ms -3.13 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.66 s ± 97 ms 3.61 s ± 51 ms -1.35 %
arco-pro_production-mode_traverse-chunk-modules + exec 3.65 s ± 70 ms 3.55 s ± 84 ms -2.83 %
threejs_development-mode_10x + exec 1.5 s ± 22 ms 1.48 s ± 21 ms -1.02 %
threejs_development-mode_10x_hmr + exec 780 ms ± 18 ms 768 ms ± 20 ms -1.63 %
threejs_production-mode_10x + exec 5.38 s ± 127 ms 5.35 s ± 147 ms -0.62 %
10000_big_production-mode_disable-minimize + rss memory 9517 MiB ± 179 MiB 9665 MiB ± 343 MiB +1.56 %
10000_development-mode + rss memory 650 MiB ± 10.7 MiB 701 MiB ± 26.8 MiB +7.87 %
10000_development-mode_hmr + rss memory 1371 MiB ± 227 MiB 1453 MiB ± 337 MiB +5.97 %
10000_production-mode + rss memory 625 MiB ± 18.8 MiB 675 MiB ± 45.8 MiB +7.95 %
arco-pro_development-mode + rss memory 589 MiB ± 30.1 MiB 621 MiB ± 27.9 MiB +5.47 %
arco-pro_development-mode_hmr + rss memory 635 MiB ± 85.2 MiB 651 MiB ± 65 MiB +2.58 %
arco-pro_production-mode + rss memory 749 MiB ± 48.7 MiB 769 MiB ± 36.4 MiB +2.67 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory 725 MiB ± 45.5 MiB 743 MiB ± 35.6 MiB +2.54 %
arco-pro_production-mode_traverse-chunk-modules + rss memory 734 MiB ± 41.6 MiB 755 MiB ± 38.6 MiB +2.82 %
threejs_development-mode_10x + rss memory 589 MiB ± 20.5 MiB 688 MiB ± 39.2 MiB +16.78 %
threejs_development-mode_10x_hmr + rss memory 1135 MiB ± 200 MiB 1200 MiB ± 282 MiB +5.71 %
threejs_production-mode_10x + rss memory 852 MiB ± 24.9 MiB 921 MiB ± 41.1 MiB +8.01 %

Please sign in to comment.