Fix query params issue dependent on bug in httpx<0.28 #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
Add test case to ensure a shard is created after the tenant creation Signed-off-by: Rodrigo Lopez <[email protected]>
rlmanrique
force-pushed
the
rodrigo/add_shard_tenant_test
branch
from
93c1e68 to
cf15efe
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1482 +/- ##
==========================================
- Coverage 93.98% 89.94% -4.04%
==========================================
Files 221 174 -47
Lines 21332 14919 -6413
==========================================
- Hits 20048 13419 -6629
- Misses 1284 1500 +216 ☔ View full report in Codecov by Sentry. |
dirkkul
changed the title
rlmanrique
commented
Dec 13, 2024
tsmith023
changed the title
tsmith023
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Thank you very much for finding and raising this bug! @rlmanrique 😁
I'll push a new version with this fix now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are running into this bug/change with httpx: encode/httpx#3433
This PR: