Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Third party errors #1357

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[WIP] Third party errors #1357

wants to merge 4 commits into from

Conversation

dirkkul
Copy link
Collaborator

@dirkkul dirkkul commented Oct 22, 2024

No description provided.

Provider: {provider_name}
Error code: {error_code}
Error from provider: {provider_error}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyedit suggestion: Wdyt about:

msg = f"""Query {request_id_str} failed:

Provider ({provider_name}) service error {error_code}.

Error details:

{'Provider:':>25} {provider_name}
{'Provider error code:':>25} {error_code}
{'Provider message:':>25} {provider_error}

Weaviate error message:

{full_error}"""

Mainly to really clarify what part of the message comes from the provider? (Also for right-aligning the structured part, which - not important either way)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants