Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cop to guard again ActiveRecord::Base.transaction use #104

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Add cop to guard again ActiveRecord::Base.transaction use #104

merged 1 commit into from
Jan 12, 2024

Conversation

desheikh
Copy link
Contributor

Add cop to prevent usage of ActiveRecord::Base.transaction {}. We should use
Model.transaction {} or
ApplicationRecord.transaction {}

@desheikh desheikh requested a review from a team as a code owner January 12, 2024 03:19
@desheikh desheikh merged commit 12a9999 into main Jan 12, 2024
4 checks passed
@desheikh desheikh deleted the add-activerecord-base-transaction-use-cop branch January 12, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylermarien tylermarien tylermarien approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@desheikh @tylermarien