Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AWS Helper plugin #8864

Merged
merged 1 commit into from
Mar 2, 2024
Merged

Conversation

cibinmathew
Copy link
Contributor

  • I'm the package's author and/or maintainer.
  • I have have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • If my package is a syntax it is named after the language it supports (without suffixes like "syntax" or "highlighting").
  • I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

My package is AWS Helper: https://github.com/cibinmathew/sublime-aws-helper

This plugin helps to validate IAM policy json from editor. It uses aws access analyser api. Error findings are listed in details in a separate tab. The plugin makes use of accessanalyzer from boto3 library.

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: AWS Helper

Packages added:
  - AWS Helper

Processing package "AWS Helper"
  - All checks passed

@braver
Copy link
Collaborator

braver commented Feb 28, 2024

Thanks for your submission and sorry for taking a while to review it.

You didn't list boto3 in your dependencies, so it looks like your package won't work?

@braver braver added feedback provided mergeable The PR is in a mergeable state but awaiting some final comments/acknowledgement from either side labels Feb 28, 2024
@cibinmathew
Copy link
Contributor Author

Thanks for your submission and sorry for taking a while to review it.

You didn't list boto3 in your dependencies, so it looks like your package won't work?

Thanks. Updated now

@braver
Copy link
Collaborator

braver commented Mar 1, 2024

Alright, please tag a new release with those latest changes.

@cibinmathew
Copy link
Contributor Author

Alright, please tag a new release with those latest changes.

Done

@braver braver merged commit 96d9813 into wbond:master Mar 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback provided mergeable The PR is in a mergeable state but awaiting some final comments/acknowledgement from either side
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants