Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename auto dark plugin #8856

Merged
merged 2 commits into from
Dec 29, 2023
Merged

rename auto dark plugin #8856

merged 2 commits into from
Dec 29, 2023

Conversation

smac89
Copy link
Contributor

@smac89 smac89 commented Dec 20, 2023

  • I'm the package's author and/or maintainer.
  • I have have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • If my package is a syntax it is named after the language it supports (without suffixes like "syntax" or "highlighting").
  • I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

My package is AutoDarkLinux (Previously Auto Dark mode for Linux)

There are no packages like it in Package Control.

@braver
Copy link
Collaborator

braver commented Dec 20, 2023

You also need to change its position in the list.

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Packages modified:
  - AutoDarkLinux

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Packages modified:
  - AutoDarkLinux

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: AutoDarkLinux

Packages added:
  - AutoDarkLinux

Processing package "AutoDarkLinux"
  - All checks passed

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Packages modified:
  - AutoDarkLinux

@smac89
Copy link
Contributor Author

smac89 commented Dec 22, 2023

@braver Fixed!

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Packages modified:
  - AutoDarkLinux

@braver
Copy link
Collaborator

braver commented Dec 23, 2023

Sorry, forgot all about the main thing with renaming packages: you need to add the previous name, as an array, under the “previous_names” key. You can find plenty of examples of this. Doing so will ensure existing users are migrated to the new name, and keeps the index tidy.

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Packages modified:
  - AutoDarkLinux

@smac89
Copy link
Contributor Author

smac89 commented Dec 27, 2023

@braver done

@braver
Copy link
Collaborator

braver commented Dec 29, 2023

Thanks, but please revert all the formatting changes to other entries.

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Packages modified:
  - AutoDarkLinux

@braver braver merged commit f172f85 into wbond:master Dec 29, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants