Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix red mask style for chromium browsers #481

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented Jan 13, 2025

Description

This pull request applies a style fix for a red mask that can be seen in Chrome browser. This has been patched in OpenSearch 2.17.1.

Issues Resolved

wazuh/wazuh-dashboard-plugins#7223

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@asteriscos asteriscos self-assigned this Jan 13, 2025
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🟢

Safari

Screen.Recording.2025-01-13.at.6.38.46.PM.mov

Firefox

Screen.Recording.2025-01-13.at.6.40.01.PM.mov

Chrome

Screen.Recording.2025-01-13.at.6.37.45.PM.mov

Copy link

@guidomodarelli guidomodarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legend:
⚫ 🠆 The test hasn't started yet.
🟢 🠆 All checks passed.
🟡 🠆 There is at least one expected fail or skipped test and no failures.
🔴 🠆 There is at least one failed check.
⚪ 🠆 Doesn't apply.
🔧 🠆 Request changes.

CR 🟢
TEST 🟢

CHROME - 🟢

Peek.2025-01-13.17-52.mp4

FIREFOX - 🟢

Peek.2025-01-13.17-53.mp4

@Desvelao Desvelao merged commit 7204360 into 4.10.1 Jan 14, 2025
60 checks passed
@Desvelao Desvelao deleted the bug/7223-data-grid-columns-red-mask-style-fix branch January 14, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Events tab data grid performance improvement
4 participants