forked from opensearch-project/OpenSearch-Dashboards
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify action to allow uploading artifact to S3 #151
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## 4.9.0 #151 +/- ##
==========================================
- Coverage 66.98% 66.97% -0.02%
==========================================
Files 3300 3300
Lines 63585 63585
Branches 10141 10141
==========================================
- Hits 42594 42584 -10
- Misses 18529 18537 +8
- Partials 2462 2464 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
asteriscos
approved these changes
Mar 20, 2024
Tostti
added a commit
that referenced
this pull request
Apr 5, 2024
yenienserrano
pushed a commit
that referenced
this pull request
Jun 18, 2024
yenienserrano
pushed a commit
that referenced
this pull request
Jul 12, 2024
yenienserrano
pushed a commit
that referenced
this pull request
Aug 19, 2024
yenienserrano
pushed a commit
that referenced
this pull request
Oct 28, 2024
yenienserrano
pushed a commit
that referenced
this pull request
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to provide the building action with the capacity of uploading the pacakges to the S3 bucket. It also tests the packages before uploading them.
Issues Resolved
#147
Evidence
If everything is fine, the packages will be uploaded

If only one type of package is selected, only that will be built and uploaded

If something fails, the packages will not be uploaded

Check List
yarn test:jest
yarn test:jest_integration