Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify action to allow uploading artifact to S3 #151

Merged
merged 22 commits into from
Mar 20, 2024

Conversation

Tostti
Copy link
Member

@Tostti Tostti commented Mar 6, 2024

Description

This PR aims to provide the building action with the capacity of uploading the pacakges to the S3 bucket. It also tests the packages before uploading them.

Issues Resolved

#147

Evidence

If everything is fine, the packages will be uploaded
image

If only one type of package is selected, only that will be built and uploaded
image

If something fails, the packages will not be uploaded
image

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Tostti Tostti changed the title MOdify action to allow uploading artifact to S3 Modify action to allow uploading artifact to S3 Mar 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.97%. Comparing base (c8fa56a) to head (b256ebf).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##            4.9.0     #151      +/-   ##
==========================================
- Coverage   66.98%   66.97%   -0.02%     
==========================================
  Files        3300     3300              
  Lines       63585    63585              
  Branches    10141    10141              
==========================================
- Hits        42594    42584      -10     
- Misses      18529    18537       +8     
- Partials     2462     2464       +2     
Flag Coverage Δ
Linux_1 35.23% <ø> (ø)
Linux_2 55.16% <ø> (ø)
Linux_3 43.86% <ø> (-0.01%) ⬇️
Windows_1 35.26% <ø> (-0.04%) ⬇️
Windows_2 55.13% <ø> (ø)
Windows_3 43.87% <ø> (ø)
Windows_4 35.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tostti Tostti marked this pull request as ready for review March 20, 2024 11:30
@Tostti Tostti merged commit f066302 into 4.9.0 Mar 20, 2024
22 checks passed
@Tostti Tostti deleted the modify-action-to-upload-to-s3 branch March 20, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants