Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added comma separators to numbers #7233

Merged
merged 14 commits into from
Jan 14, 2025
Merged

Added comma separators to numbers #7233

merged 14 commits into from
Jan 14, 2025
+30 −6

Conversation

JuanGarriuz
Copy link
Member

@JuanGarriuz JuanGarriuz commented Jan 13, 2025 •
edited
Loading

Description

Added comma separators to numbers in all UI

Issues Resolved

Evidence

Evidences

These responses are mocked

image
image
image
image
image
image
image
image
image
image
image

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
Check throughout the application that the numbers displayed on the interface have the expected parsing. ⚫ ⚫ ⚫

There might be more areas in the application that display numbers; it would be good to double-check.

  • Home
  • Vulnerability detection
  • Nist
  • GitHub
  • Office365
  • Summary
  • Decoders
  • Rules
  • Cluster

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@JuanGarriuz JuanGarriuz self-assigned this Jan 13, 2025
@JuanGarriuz JuanGarriuz linked an issue Jan 13, 2025 that may be closed by this pull request
Add comma separators to numbers #7231
Closed
@JuanGarriuz JuanGarriuz marked this pull request as ready for review January 13, 2025 16:10
@chantal-kelm chantal-kelm self-requested a review January 13, 2025 17:09
chantal-kelm
chantal-kelm previously approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
TEST: ✅

Captura de pantalla 2025-01-13 a la(s) 2 52 59 p  m Captura de pantalla 2025-01-13 a la(s) 2 52 50 p  m Captura de pantalla 2025-01-13 a la(s) 2 50 10 p  m

@guidomodarelli guidomodarelli self-requested a review January 13, 2025 18:43
@chantal-kelm chantal-kelm self-requested a review January 14, 2025 11:08
chantal-kelm
chantal-kelm previously approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
TEST: ✅

Captura de pantalla 2025-01-14 a la(s) 8 08 16 a  m Captura de pantalla 2025-01-14 a la(s) 8 08 04 a  m Captura de pantalla 2025-01-14 a la(s) 8 06 26 a  m Captura de pantalla 2025-01-14 a la(s) 8 05 17 a  m

guidomodarelli
guidomodarelli previously approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@guidomodarelli guidomodarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legend:
⚫ 🠆 The test hasn't started yet.
🟢 🠆 All checks passed.
🟡 🠆 There is at least one expected fail or skipped test and no failures.
🔴 🠆 There is at least one failed check.
⚪ 🠆 Doesn't apply.
🔧 🠆 Request changes.

CR 🟢
TEST 🟢

image
image

asteriscos
asteriscos requested changes Jan 14, 2025
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test: 🔴
The vulnerabilities KPI's still don't have comma separators.
image

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.5% ( 400 / 879 )
Branches 41.09% ( 157 / 382 )
Functions 43.87% ( 136 / 310 )
Lines 45.69% ( 398 / 871 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 78.72% ( 185 / 235 )
Branches 62.72% ( 69 / 110 )
Functions 61.7% ( 29 / 47 )
Lines 78.72% ( 185 / 235 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 14.92% ( 4448 / 29802 )
Branches 9.77% ( 1879 / 19222 )
Functions 14.67% ( 1058 / 7211 )
Lines 15.14% ( 4342 / 28673 )

yenienserrano
yenienserrano approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🟢

image
image
image

@guidomodarelli
Copy link
Contributor

LGTM 🟢

image
image
image

guidomodarelli
guidomodarelli approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@guidomodarelli guidomodarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🟢

asteriscos
asteriscos approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢
Test: 🟢

image

image

@asteriscos asteriscos merged commit c27931e into 4.10.1 Jan 14, 2025
5 checks passed
@asteriscos asteriscos deleted the enhacement/7231-add-commma-separators-to-numbers branch January 14, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yenienserrano yenienserrano yenienserrano approved these changes

@guidomodarelli guidomodarelli guidomodarelli approved these changes

@asteriscos asteriscos asteriscos approved these changes

@chantal-kelm chantal-kelm Awaiting requested review from chantal-kelm

Assignees

@JuanGarriuz JuanGarriuz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add comma separators to numbers
5 participants
@JuanGarriuz @guidomodarelli @asteriscos @yenienserrano @chantal-kelm