-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unpin docusaurus-og commit #1811
Conversation
WalkthroughThe pull request involves a modification to the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
docs/package.json (2)
27-27
: Document the dependency management strategy.Since we're moving away from commit pinning, consider adding a comment in the package.json or updating the repository documentation to explain this intentional choice and its implications for the build process.
Add a comment above the dependency:
+ // Intentionally unpinned to reduce maintenance overhead. Main branch is protected. "@waveterm/docusaurus-og": "https://github.com/wavetermdev/docusaurus-og.git",
27-27
: Consider implementing a monitoring strategy.To maintain stability while using an unpinned dependency, consider:
- Setting up automated checks for breaking changes in the docusaurus-og repository
- Implementing a notification system for main branch updates
Would you like me to help create an issue to track the implementation of these monitoring measures?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lock
is excluded by!**/yarn.lock
,!**/*.lock
📒 Files selected for processing (1)
docs/package.json
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: Build Docsite
- GitHub Check: merge-gatekeeper
- GitHub Check: Analyze (go)
- GitHub Check: Build for TestDriver.ai
🔇 Additional comments (1)
docs/package.json (1)
27-27
: Verify branch protection rules for the docusaurus-og fork.While unpinning the commit aligns with reducing maintenance overhead, we should ensure the main branch of
wavetermdev/docusaurus-og
has appropriate protection rules to maintain stability.Run this script to check branch protection rules:
Too annoying to keep updating the commit, instead I've locked down the main branch for the docusaurus-og fork.