-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initialize function to fsapi #1501
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense with the suggested changes. I need to look it over one more time though, maybe the initialize
internal method can be dropped entirely, not sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes/Resolves:
Summary/Motivation:
The parameter sweep tool (see UI PR#103) with parallel capabilities allows for an optional initialize function. in the case that there is no initialize function, it runs the build function multiple times. This takes a long time. If the UI can access a models initialize function, then parameter sweep run times can be decreased.
Changes proposed in this PR:
do_initailize
functionLegal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: