Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wasmcloud:[email protected] #3765

Merged
merged 9 commits into from
Dec 5, 2024

Conversation

rvolosatovs
Copy link
Member

@rvolosatovs rvolosatovs commented Dec 4, 2024

This adds support for wasmcloud:[email protected], which is effectively just renamed WebAssembly/wasi-messaging@4ee59bb

Tested with a newly-added wasmcloud:[email protected] example manually

Note, that wadm, wash or something in-between does not support incoming-handler interface names for links, but that does not really matter, because these interface names do not appear to ever really be used by providers

Note: binary providers are expected to use wasmcloud:[email protected] for the time being

@rvolosatovs rvolosatovs force-pushed the feat/messaging-0-3-0 branch 2 times, most recently from b758399 to bb177a8 Compare December 4, 2024 19:30
@rvolosatovs rvolosatovs marked this pull request as ready for review December 4, 2024 19:34
@rvolosatovs rvolosatovs requested review from a team as code owners December 4, 2024 19:34
@rvolosatovs rvolosatovs enabled auto-merge December 4, 2024 19:34
Copy link
Member

@brooksmtownsend brooksmtownsend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few asks re: OTEL and then a potentially blocking question regarding the implementation of the 0.3 messaging interface. It makes sense that it works, but I wasn't sure if it should be tightly coupled to NATS

crates/runtime/src/component/messaging/v0_3.rs Outdated Show resolved Hide resolved
crates/host/src/wasmbus/handler.rs Show resolved Hide resolved
crates/host/src/wasmbus/handler.rs Outdated Show resolved Hide resolved
@rvolosatovs rvolosatovs requested a review from a team as a code owner December 4, 2024 20:11
Signed-off-by: Roman Volosatovs <[email protected]>
Signed-off-by: Roman Volosatovs <[email protected]>
@rvolosatovs
Copy link
Member Author

rvolosatovs commented Dec 4, 2024

To make sure we're on the same page: implementation is not (and was not) tightly coupled to NATS.io, it's fully generic

@rvolosatovs
Copy link
Member Author

Changed content-type errors to warn logs and filed an issue upstream WebAssembly/wasi-messaging#30

Also filed this PR WebAssembly/wasi-messaging#29 to avoid having to trap when content-type is not supported

Copy link
Member

@brooksmtownsend brooksmtownsend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me

@rvolosatovs rvolosatovs added this pull request to the merge queue Dec 5, 2024
Merged via the queue into wasmCloud:main with commit 7cf33ec Dec 5, 2024
102 checks passed
@rvolosatovs rvolosatovs deleted the feat/messaging-0-3-0 branch December 5, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants