-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: wasmcloud:[email protected]
#3765
Conversation
Signed-off-by: Roman Volosatovs <[email protected]>
Signed-off-by: Roman Volosatovs <[email protected]>
b758399
to
bb177a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few asks re: OTEL and then a potentially blocking question regarding the implementation of the 0.3 messaging interface. It makes sense that it works, but I wasn't sure if it should be tightly coupled to NATS
Signed-off-by: Roman Volosatovs <[email protected]>
Signed-off-by: Roman Volosatovs <[email protected]>
Signed-off-by: Roman Volosatovs <[email protected]>
Signed-off-by: Roman Volosatovs <[email protected]>
bb177a8
to
e7b06b4
Compare
Signed-off-by: Roman Volosatovs <[email protected]>
Signed-off-by: Roman Volosatovs <[email protected]>
To make sure we're on the same page: implementation is not (and was not) tightly coupled to NATS.io, it's fully generic |
Signed-off-by: Roman Volosatovs <[email protected]>
Changed Also filed this PR WebAssembly/wasi-messaging#29 to avoid having to trap when content-type is not supported |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for me
This adds support for
wasmcloud:[email protected]
, which is effectively just renamed WebAssembly/wasi-messaging@4ee59bbTested with a newly-added
wasmcloud:[email protected]
example manuallyNote, that wadm, wash or something in-between does not support
incoming-handler
interface names for links, but that does not really matter, because these interface names do not appear to ever really be used by providersNote: binary providers are expected to use
wasmcloud:[email protected]
for the time being