-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: allow embedding wadm #548
Merged
brooksmtownsend
merged 9 commits into
wasmCloud:main
from
brooksmtownsend:refactor/for-embedding-wadm
Jan 17, 2025
Merged
refactor: allow embedding wadm #548
brooksmtownsend
merged 9 commits into
wasmCloud:main
from
brooksmtownsend:refactor/for-embedding-wadm
Jan 17, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brooks Townsend <[email protected]>
Signed-off-by: Brooks Townsend <[email protected]>
Signed-off-by: Brooks Townsend <[email protected]>
9996d95
to
58e60a7
Compare
Signed-off-by: Brooks Townsend <[email protected]>
58e60a7
to
472dd32
Compare
Signed-off-by: Brooks Townsend <[email protected]>
f2f3235
to
7507a8d
Compare
Signed-off-by: Brooks Townsend <[email protected]>
7507a8d
to
7e81163
Compare
Signed-off-by: Brooks Townsend <[email protected]>
Signed-off-by: Brooks Townsend <[email protected]>
3b97de7
to
228873b
Compare
thomastaylor312
requested changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly nits but one minor concern around public functions in one of the moved files
Signed-off-by: Brooks Townsend <[email protected]>
thomastaylor312
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This PR reorganizes most of the code from
src/main.rs
to be under thewadm
crate instead so that Rust developers can embed wadm into their own library. This is primarily useful with thestart_wadm
function, which can be called with aWadmConfig
struct with all wadm configuration options. If using in a CLI, thecli
feature should be enabled in thewadm
crate to enable the clap attributes to work.Related Issues
Required for wasmCloud/wasmCloud#1061
Release Information
wadm-cli 0.20.0
wadm 0.20.0
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification