feat(deps): add separate wit-wasm and wit-std features #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: luk3ark <[email protected]>
Signed-off-by: luk3ark <[email protected]>
Signed-off-by: luk3ark <[email protected]>
|
as a note - with this current setup it is currently only possible to depend in a wasm context when the wadm-types dependency has default-features = false otherwise, tokio causes problems |
Signed-off-by: luk3ark <[email protected]>
Signed-off-by: luk3ark <[email protected]>
|
default-features flag no longer needed for wasm-target compilation |
brooksmtownsend
approved these changes
Jan 2, 2025
|
tested manually, all LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now wadm-types has only been depended on from a std context, however it would be useful to use it in wasm targets
Change syncs latest wadm-types and allows them to be used in both wasm and std contexts
I couldn't really think of a cleaner way to do the feature gates, open to suggestions