Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netsh: profiles: use line no and regex to parse "Key contents" #11

Closed
wants to merge 1 commit into from
Closed

Conversation

ipodipad
Copy link

@ipodipad ipodipad commented Jul 5, 2020

Previously, "Key contents" is used to extract passphrase from the console
netsh command. However, Microsoft internally hard-coded i18n elements in
the netsh and could not be reverted to English unless installing
language pack for another Language,
Thus it distracts for this program to parse sementic without making an
effort to translate the keyword

So, intead of keyword, use line number where it print out to the console
to provide service not being affected by i18n.

This feature closes #4
This feature closes #7

…of keyword itself

Previously "Key contents" is used to extract passphrase from the console
netsh command. However, Microsoft internally hard-coded i18n elements in
the netsh and could not be reverted to English unless installing
language pack for another Language,
Thus it distracts for this program to parse sementic without making an
effort to translate the keyword

So, intead of keyword, use line number where it print out to the console
to provide service not being affected by i18n.

This feature closes #4
This feature closes #7
@warengonzaga
Copy link
Owner

Hello @ipodipad, you don't need to edit the .bat code since it is auto generated and based on core.bat file on source folder. Can you edit the core.bat and follow the generation process?

  • Download the repository
  • Do "npm install" and "npm install gulp-cli -g && npm install gulp -D".
  • Edit the core.bat in source folder.
  • When you think you are satisfy, just do "gulp build" or "gulp" to initiate the building process.
  • If you want to reset the building process just do "gulp cleandev".
  • If you are editing the "./src/core.bat" you can use "gulp test" it is a combination of "gulp build" and "gulp cleandev" so you can quickly quality check the production build.
  • Do "gulp --tasks" to see all available "gulp" commands.

Also... make a pull request on dev branch... don't PR directly to master branch. Thank you!

Copy link
Owner

@warengonzaga warengonzaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit only the core.bat file in source folder.

@warengonzaga
Copy link
Owner

@ipodipad thank you for your contribution and suggested changes to make this available to all language. I hard coded your idea to v4 of this program and will release the new version tomorrow. Thank you for your brilliant approach... I will add your name to the changelog of this update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants