add back private key clean up

wangweij · Jan 31, 2025 · 2568238 · 2568238
1 parent b24065d
commit 2568238
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/src/java.base/share/classes/sun/security/provider/ML_DSA_Impls.java b/src/java.base/share/classes/sun/security/provider/ML_DSA_Impls.java
@@ -80,11 +80,15 @@ protected byte[][] implGenerateKeyPair(String name, SecureRandom sr) {
             r.nextBytes(seed);
             ML_DSA mlDsa = new ML_DSA(name2int(name));
             ML_DSA.ML_DSA_KeyPair kp = mlDsa.generateKeyPairInternal(seed);
-            return new byte[][]{
-                    mlDsa.pkEncode(kp.publicKey()),
-                    seed,
-                    mlDsa.skEncode(kp.privateKey())
-            };
+            try {
+                return new byte[][]{
+                        mlDsa.pkEncode(kp.publicKey()),
+                        seed,
+                        mlDsa.skEncode(kp.privateKey())
+                };
+            } finally {
+                kp.privateKey().destroy();
+            }
         }
     }